Created attachment 307725 [details] gtkdiskfree-2.0.0.ebuild As discussed in: https://bugs.gentoo.org/show_bug.cgi?id=370605 gtkdiskfree have the vocation to be pushed out from the portage tree I released a new version of this software as maintainer. This new version is GTK3 compliant. But before to be integrated in gentoo, code need to be audited.
would you attach a diff too?
Created attachment 307727 [details] gtkdiskfree-2.0.0.patch
Created attachment 307729 [details, diff] gtkdiskfree-2.0.0.ebuild.patch (In reply to comment 1) Of course, but ebuild or source patch (related to my request to audit code) ? I attached both.
Are you willing to proxy maintain this in Gentoo too? In that case I can proxy you: http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml --- /usr/portage/app-admin/gtkdiskfree/gtkdiskfree-1.9.3-r1.ebuild 2012-03-28 00:31:01.000000000 +0700 +++ /usr/gentoo/overlay/various/app-admin/gtkdiskfree/gtkdiskfree-2.0.0.ebuild 2012-04-04 16:11:06.000000000 +0700 @@ -6,30 +6,28 @@ inherit eutils DESCRIPTION="Graphical tool to show free disk space" -HOMEPAGE="http://gentoo.org/" -SRC_URI="mirror://gentoo/${P}.tar.gz" +HOMEPAGE="https://gitorious.org/gtkdiskfree" +SRC_URI="https://gitorious.org/${PN}/master/archive-tarball/master -> ${P}.tar.gz" This is not a good idea as "master" will probably change from time to time and, then, manifest would need to be regenerated each time. The way to go is to package master when you feel it's safe and release new versions LICENSE="GPL-2" SLOT="0" -KEYWORDS="amd64 ia64 ppc ppc64 sparc x86" -IUSE="nls" +KEYWORDS="~amd64" +IUSE="gtk3 nls" -RDEPEND="x11-libs/gtk+:2" +RDEPEND="gtk3? ( x11-libs/gtk+:3 ) + !gtk3? ( x11-libs/gtk+:2 )" The idea is to only support gtk3, see bug 374057 for reasoning (theming issues are fixed in newer gtk+:2 and 3 versions, that will be stabilized in bug 410611 DEPEND="${RDEPEND} dev-util/pkgconfig nls? ( sys-devel/gettext )" -src_prepare() { - epatch \ - "${FILESDIR}"/${P}-tempfile.patch \ - "${FILESDIR}"/${PV}-makefile-DESTDIR.patch \ - "${FILESDIR}"/${P}-make-382.patch Looks like you merged this patches, nice :D Not sure if more patches are being applied by other distributions :-/ +S=${WORKDIR}/${PN}-master +src_prepare() { echo 'Categories=GTK;System;Filesystem;' >> gtkdiskfree.desktop } Can you please include this fix also in your fork? That way we can drop this downstream
Looks like only debian is still providing it, this are their patches: http://patch-tracker.debian.org/package/gtkdiskfree
1 (In reply to comment 4) 1 1. I can proxy maintain. But, I would like the code to be checked prior to this. 1 2. SRC_URI: yes, it's ugly, but I didn't yet understood howto release on gitorious. 1 3. gtk3 flag: The workaround here would be to replace gtk3 flag by gtk2 one (enabling gtk3 by default and gtk2 if specified), following gentoo roadmap, without breaking flexible approach from the distro. I disagree on disabling gtk2 from any ebuild, there's already a lot of distro where choices are sealed by devs. 1 4. you're right gentoo patchset was applied on source prior to any changes. for the desktop file, I was planning to apply change at next commit. (In reply to comment 5) I will take a look at debian patches P.S.: 1 3: gnome-mplayer ebuild although gtk3 support isn't full, doesn't allow to use gtk2. But a basic features as progress bar isn't working with gtk3 when playing a ogg.
(In reply to comment #6) > 1 (In reply to comment 4) > 1 1. I can proxy maintain. But, I would like the code to be checked prior to > this. I don't have much knowledge about this, will CC gnome team to see if anybody else can > 1 2. SRC_URI: yes, it's ugly, but I didn't yet understood howto release on > gitorious. > 1 3. gtk3 flag: The workaround here would be to replace gtk3 flag by gtk2 > one (enabling gtk3 by default and gtk2 if specified), following gentoo > roadmap, without breaking flexible approach from the distro. I disagree on > disabling gtk2 from any ebuild, there's already a lot of distro where > choices are sealed by devs. > 1 4. you're right gentoo patchset was applied on source prior to any changes. > for the desktop file, I was planning to apply change at next commit. > > > > (In reply to comment 5) > I will take a look at debian patches > > P.S.: 1 3: gnome-mplayer ebuild although gtk3 support isn't full, doesn't > allow to use gtk2. But a basic features as progress bar isn't working with > gtk3 when playing a ogg. -> For that specific case, please report a bug telling gnome-mplayer maintainers about that missing feature. But, regarding gtkdiskfree, I will only add a gtk3 build as I strongly agree with current policy of use latest gtk when possible instead of having various options that causes a lot of problems in the past when gtk1 gtk2 migration (feel free to drop in #gentoo-desktop IRC channel and ask to gnome team members ;))
Created attachment 307853 [details, diff] gtkdiskfree-2.0.0.ebuild.patch Applied one debian patch and added their german translation. (In reply to comment 6) > For that specific case, please report a bug telling gnome-mplayer maintainers > about that missing feature Bunch of bugs have been opened already. > But, regarding gtkdiskfree, I will only add a gtk3 build Under this constraint I do not which to proxy maintain. > various options that causes a lot of problems in the past when gtk1 gtk2 Many project maintainers migrate to gtk3 faster than ten years ago when need to migrate to gtk2. I which to believe in: We produce Gentoo Linux, a special flavor of Linux that can be automatically optimized and customized for just about any application or need. What about saying support is done only gtk3 (when available, think about gimp), but still allow use of gtk2 ?
The question is about supporting multiple gtk versions or only one, the current policy (established after problems in the past trying to support various versions with gtk1 -> gtk2 migration) states we should support either gtk2 or gtk3 (and try to use latest if possible)
(In reply to comment 9) So the new patch for the ebuild follows the policy, enabling gtk3 by default, though allowing gtk2 with useflag. (I will also change the configure.in to follow this behavior, default to gtk3 and gtk2 on explicit demand) I also agree with this policy, else I wouldn't migrate an old project to gtk3. Hope there will be no gtk2 only ebuilds ten years after. But not allowing user to compile with gtk2 when possible (as in gnome-mplayer), seems to me really sharp.
(In reply to comment #10) > (In reply to comment 9) > > So the new patch for the ebuild follows the policy, enabling gtk3 by > default, though allowing gtk2 with useflag. It doesn't, I thought I explained it already, you can refer to bug 374057 and his duplicates for more info. > (I will also change the configure.in to follow this behavior, default to > gtk3 and gtk2 on explicit demand) > I also agree with this policy, else I wouldn't migrate an old project to > gtk3. Hope there will be no gtk2 only ebuilds ten years after. > But not allowing user to compile with gtk2 when possible (as in > gnome-mplayer), seems to me really sharp. We are talking here about gtkdiskfree ;), regarding gnome-mplayer, I don't maintain it, only use it from time to time when totem fails for me and didn't even now his gtk3 GUI had regressions over gtk2 one -> go to the bug you just opened then for it
Sorry to ennoy you, as every people asking for gtk2 are marked as resolved wontfix I close the thread myself
(In reply to comment #12) > Sorry to ennoy you, as every people asking for gtk2 are marked as resolved > wontfix I close the thread myself I am not annoyed at all, we simply disagree but that is all. I really appreciate your involvement on this :) Maybe somebody else goes ahead and bumps it with gtk3 support only even without proxy maintainance :-/ (Me not for now because my only relation with this package is due me looking to orphan packages :S)
Created attachment 307977 [details, diff] gtkdiskfree-2.0.1.ebuild.patch Changed the desktop file. Automatised the install for icon and desktop file. Ebuild is more lightweight.
Hi Samuel, still willing to co-maintain? I would serve as proxy comitter (and just committed your suggestions to the tree). I just put the tarball on the gentoo miror directly (fetch wasn't stable). Greetings, Michael
+*gtkdiskfree-2.0.1 (19 Apr 2012) + + 19 Apr 2012; Michael Weber <xmw@gentoo.org> +gtkdiskfree-2.0.1.ebuild: + Version bump as suggested by Samuel BAUER (bug 410757). +
(In reply to comment 15) > still willing to co-maintain? Of course, this is for the best, if somebody is using it and opens a bug, it will allow me to work on it faster.
Thank you! + 19 Apr 2012; Michael Weber <xmw@gentoo.org> metadata.xml: + Proxy-maint with Samuel Bauer. +
