Bug 410737 – Please review the prefix patch to docbook-sgml-utils-0.6.14-r1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benda Xu 2012-04-04 01:39:40 UTC]

In the attachment are the patches necessary to compile docbook-sgml-utils in a prefix environment. For the new keywords, cf. bug #410301.

Please comment on the patch for me to refine it. Thanks.

Reproducible: Always

[Comment 1 Benda Xu 2012-04-04 01:43:20 UTC]

Created attachment 307701 [details, diff]
docbook-sgml-utils-0.6.14-r1.patch

patch to the ebuild

[Comment 2 Benda Xu 2012-04-04 01:44:06 UTC]

Created attachment 307703 [details, diff]
docbook-utils-0.6.14-prefix.patch

patch to the source tree to make it prefix aware

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2012-04-04 02:01:24 UTC]

*** Bug 410301 has been marked as a duplicate of this bug. ***

[Comment 4 Mike Gilbert 2012-04-04 02:07:56 UTC]

This doesn't look like it will break anything on non-prefix systems, so I'm fine with it.

That bit in backends/txt is a bit ugly; ideally it would just look for those commands in $PATH (command -v lynx ...). That's outside the scope of your prefix changes, however.

I'm not sure how the sgml tools (openjade, etc) will respond to having the sgml catalogs somewhere other than /etc/sgml. sgml-catalog.eclass already puts them in $EPREFIX/etc/sgml, so maybe it just works?

[Comment 5 Benda Xu 2012-04-04 02:47:28 UTC]

(In reply to comment #4)
> This doesn't look like it will break anything on non-prefix systems, so I'm
> fine with it.

Thanks :) Let me commit it then.

> That bit in backends/txt is a bit ugly; ideally it would just look for those
> commands in $PATH (command -v lynx ...). That's outside the scope of your
> prefix changes, however.

Hmm... sometimes command -v expanding to shell alias:

$ command -v ls
alias ls='ls --color=auto'

> I'm not sure how the sgml tools (openjade, etc) will respond to having the
> sgml catalogs somewhere other than /etc/sgml. sgml-catalog.eclass already
> puts them in $EPREFIX/etc/sgml, so maybe it just works?

Yes, it just works. It has been in prefix overlay for 4 years:

http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/app-text/docbook-sgml-utils?rev=60416

And packages which uses docbook2man, like app-emulation/lxc, compiles well.

[Comment 6 Benda Xu 2012-04-04 03:21:38 UTC]

Commited and got repoman's complain about RDEPEND

RDEPEND.implicit              2
app-text/docbook-sgml-utils/docbook-sgml-utils-0.6.14.ebuild: RDEPEND is not explicitly assigned
app-text/docbook-sgml-utils/docbook-sgml-utils-0.6.14-r1.ebuild: RDEPEND is not explicitly assigned