Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410229 - x11-base/xorg-server: minor adjustments to the xdm init script for kde-base/kdm (patch included)
Summary: x11-base/xorg-server: minor adjustments to the xdm init script for kde-base/k...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2012-03-30 11:13 UTC by Hans
Modified: 2012-04-29 13:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the xdm init script (xdm.diff,614 bytes, text/plain)
2012-03-30 11:13 UTC, Hans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hans 2012-03-30 11:13:01 UTC
Created attachment 307179 [details]
patch for the xdm init script

I propose to make three small changes to the xdm init script provided by xorg-server:

1) replace the EXE line in

kdm|kde)
        EXE="$(which kdm)"

with "EXE=/usr/bin/kdm", as it has been the default location for a long time.
This would make the whole entry actually redundant by the catch-all at the end, but perhaps it is preferable to keep a separate entry for this, I don't know.

2) get rid of the following entry:

kdm-*)
      EXE="/usr/kde/${MY_XDM#kdm-}/bin/kdm"
      PIDFILE=/var/run/kdm.pid

Nothing in the tree should be installing in /usr/kde anymore as far as I am aware.

3) replace the "which" command by the shell built-in "command -v", the way it is used in the net.* scripts:

*)
       # first find out if there is such executable
       EXE="$(which ${MY_XDM} 2>/dev/null)"

-->     EXE="$(command -v ${MY_XDM} 2>/dev/null)"


The attached patch includes all this. I tested it and it works for me.

Thanks for your attention.
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2012-04-19 12:40:21 UTC
Correct, it should've been removed with the kdeprefix removal.

@x11: just add xdm.initd-8. :)
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2012-04-29 13:08:24 UTC
Fixed in the live ebuild -> next xorg-server bump will have this fix.