Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410189 - media-video/mplayer: improve pkg-config support
Summary: media-video/mplayer: improve pkg-config support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL: http://lists.mplayerhq.hu/pipermail/m...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 20:10 UTC by SpanKY
Modified: 2012-04-12 23:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer pkg-config patch (mplayer-1.0_rc4-pkg-config.patch,2.61 KB, patch)
2012-03-29 20:10 UTC, SpanKY
Details | Diff
ebuild patch (mplayer.ebuild.patch,823 bytes, patch)
2012-03-29 20:10 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2012-03-29 20:10:09 UTC
Created attachment 307117 [details, diff]
mplayer pkg-config patch

current configure code hardcodes "pkg-config", and doesn't use it for libdvdread/libdvdnav.  mind if i commit the attached patch (i'll take care of upstreaming it) ?
Comment 1 SpanKY gentoo-dev 2012-03-29 20:10:22 UTC
Created attachment 307119 [details, diff]
ebuild patch
Comment 2 Alexis Ballier gentoo-dev 2012-03-29 20:33:36 UTC
(In reply to comment #0)
> Created attachment 307117 [details, diff] [details, diff]
> mplayer pkg-config patch
> 
> current configure code hardcodes "pkg-config", and doesn't use it for
> libdvdread/libdvdnav.  mind if i commit the attached patch (i'll take care
> of upstreaming it) ?

please upstream it first and apply the patch that landed there.
Comment 3 SpanKY gentoo-dev 2012-04-02 17:13:25 UTC
i've posted it there, but really, this is fixing bugs in the mplayer build system, not adding new features.  so i don't think this should wait for them to accept it before fixing it in our tree since this is causing me problems $now.
Comment 4 Alexis Ballier gentoo-dev 2012-04-05 12:55:12 UTC
well, since you got no answer from upstrem in a couple of days (which is rare usually), feel free to apply to 1.0_rc4_p20120405
Comment 5 SpanKY gentoo-dev 2012-04-05 18:34:10 UTC
it's weird ... there hasn't been traffic on the list in over a week.

i'll list myself as responsible for the patch in cvs, so feel free to hassle me if it screws things up.

i posted a similar fix to libdvdnav:
http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2012-March/001672.html

but haven't heard back there either.  mind if i update libdvdnav too ?
Comment 6 SpanKY gentoo-dev 2012-04-12 21:28:46 UTC
upstream mplayer seemed happy with the change ... just waiting for them to merge

should i file another bug for the dvdnav ebuild ?  no response there yet from upstream :/
Comment 7 Alexis Ballier gentoo-dev 2012-04-12 21:32:29 UTC
(In reply to comment #6)
> should i file another bug for the dvdnav ebuild ?  no response there yet
> from upstream :/

nah feel free to apply, patch looks sane
Comment 8 SpanKY gentoo-dev 2012-04-12 23:40:21 UTC
thanks!  i've logged myself as the owner in both patches, and will hopefully hear back from upstream at some point :/.