Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410143 - net-misc/networkmanager-0.9.4.0: allow disabling WEXT support
Summary: net-misc/networkmanager-0.9.4.0: allow disabling WEXT support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Alexandre Rostovtsev (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-03-29 13:23 UTC by Davide Pesavento
Modified: 2012-04-13 21:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Introduce USE=wext to allow disabling WEXT support (nm-no-wext.patch,2.40 KB, patch)
2012-03-29 13:24 UTC, Davide Pesavento (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Pesavento (RETIRED) gentoo-dev 2012-03-29 13:23:10 UTC
Since 0.9.4, deprecated WEXT support can be disabled by passing --with-wext=no to configure.
Comment 1 Davide Pesavento (RETIRED) gentoo-dev 2012-03-29 13:24:53 UTC
Created attachment 307069 [details, diff]
Introduce USE=wext to allow disabling WEXT support

wext is enabled by default.

While at it, I made it possible to build against libnl:3 if USE=wimax is disabled.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-03-29 18:03:42 UTC
What are the advantages of disabling wext support? As far as I can tell, it doesn't get rid of any dependencies, and doesn't appreciably decrease build time or the size of installed files.

> While at it, I made it possible to build against libnl:3 if USE=wimax is
> disabled.

I would prefer to avoid conditional patching if possible.
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2012-03-29 19:54:17 UTC
(In reply to comment #2)
> What are the advantages of disabling wext support? As far as I can tell, it
> doesn't get rid of any dependencies, and doesn't appreciably decrease build
> time or the size of installed files.
> 

I can disable WEXT in my kernel.

> > While at it, I made it possible to build against libnl:3 if USE=wimax is
> > disabled.
> 
> I would prefer to avoid conditional patching if possible.

I would agree with you in general, but in this particular case an old version of a library is being forced upon everyone just because a very small percentage of users need USE=wimax. Of course the best solution would be to port net-wireless/wimax to libnl:3, but that looks much less trivial.
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-04-13 21:19:05 UTC
Fixed in 0.9.4.0-r2.

>*networkmanager-0.9.4.0-r2 (13 Apr 2012)
>
>  13 Apr 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -networkmanager-0.9.2.0.ebuild, -networkmanager-0.9.2.0-r2.ebuild,
>  +networkmanager-0.9.4.0-r2.ebuild,
>  +files/networkmanager-0.9.4.0-force-libnl1.1-r1.patch,
>  +files/networkmanager-0.9.4.0-libnm-glib-ensure_inited.patch,
>  +files/networkmanager-0.9.4.0-libnm-glib-init-gerror.patch, metadata.xml:
>  Fix gnome-shell crashes when networkmanager is not running (thanks to
>  Firartix for reporting). Do not use obsolete wext API by default, and build
>  against libnl:3 when USE=-wimax (bug #410143, thanks to Davide Pesavento).
>  Add a separate USE flag for modemmanager because not very many people need
>  it. Drop old.