Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 409625 - media-sound/pulseaudio: ebuild should suggest people to set SND_HDA_PREALLOC_SIZE to 2048
Summary: media-sound/pulseaudio: ebuild should suggest people to set SND_HDA_PREALLOC_...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-25 12:00 UTC by Pacho Ramos
Modified: 2014-02-17 08:50 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-03-25 12:00:38 UTC
When updating kernel I got this:

CONFIG_SND_HDA_PREALLOC_SIZE:

Specifies the default pre-allocated buffer-size in kB for the
HD-audio driver.  A larger buffer (e.g. 2048) is preferred
for systems using PulseAudio.  The default 64 is chosen just
for compatibility reasons.

Note that the pre-allocation size can be changed dynamically
via a proc file (/proc/asound/card*/pcm*/sub*/prealloc), too.

This should probably be noticed too in ebuild when smaller size if used as maybe some people miss this help information when updating their kernels

Thanks a lot

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2013-06-16 12:42:01 UTC
ping
Comment 2 Pacho Ramos gentoo-dev 2014-02-16 19:37:33 UTC
Umm, I don't know how to use linux-info.eclass to achieve this :S
Comment 3 Vikraman (RETIRED) gentoo-dev 2014-02-17 06:40:49 UTC
I added a check for CONFIG_SND_HDA_PREALLOC_SIZE >= 2048.

The other issue is that calling linux-info_pkg_setup does the config
check again in pkg_setup(). What do you want to do about that?
Comment 4 Pacho Ramos gentoo-dev 2014-02-17 07:19:13 UTC
Per eclass documentation looks like it was needed:
# Before using any of the config-handling functions in this eclass, you must
# ensure that one of the following functions has been called (in order of
# preference), otherwise you will get bugs like #364041):
# linux-info_pkg_setup
# linux-info_get_any_version
# get_version
# get_running_version

But maybe it's obsolete since I have seen all the options in the tree
Comment 5 Vikraman (RETIRED) gentoo-dev 2014-02-17 07:38:51 UTC
Hm, it does make more sense to check kernel config in pkg_pretend()
instead of pkg_setup(), but I don't know why linux-info calls it
pkg_setup(). Should this check be moved to pkg_setup() then?
Comment 6 Alexander Tsoy 2014-02-17 08:36:31 UTC
(In reply to Pacho Ramos from comment #4)
> Per eclass documentation looks like it was needed:
> # Before using any of the config-handling functions in this eclass, you must
> # ensure that one of the following functions has been called (in order of
> # preference), otherwise you will get bugs like #364041):
> # linux-info_pkg_setup
> # linux-info_get_any_version
> # get_version
> # get_running_version
> 
> But maybe it's obsolete since I have seen all the options in the tree

Heh.. Seems this check is taken from lvm2/systemd ebuilds. It was originally written by me for lvm2 ebuild [1]. I don't know why ssuominen chose to commit the first version of the patch. In the second version of the patch linux_chkconfig_string() is called after check_extra_config() which calls linux-info_get_any_version() internally.

[1] https://bugs.gentoo.org/show_bug.cgi?id=479756
Comment 7 Alexander Tsoy 2014-02-17 08:50:45 UTC
(In reply to Alexander Tsoy from comment #6)
> In the second version of the patch
> linux_chkconfig_string() is called after check_extra_config() which calls
> linux-info_get_any_version() internally.

btw, pulseaudio ebuild currently does exactly the same thing. So I assume everything should work fine.