Please add it to the tree.
Renaming the ebuild to cgit-0.9.0.3.ebuild and removing the fix-xss.patch (already included in the new version) works fine here. Please bump.
Before adding the ebuild to the tree could we improve the ebuild a little bit? It's really hard to get things going for people having their hands on a cgit installation for the first time. It took me *some* hours to figure out how things work. Documentation isn't the best and a research on the web for "cgit gentoo" doesn't point out anything usefull. I collected some "bugs" and infos what I had to do in order to get this beast up & running. I'm going to post them here later the day.
Now here are some proposals. After all I'm not sure if those are fixable are just a matter of configuration. Since I setup cgit for the first time and I'm relatively new to git I might be wrong. 1. Postinstall instructions - We should point to the README -> http://hjemli.net/git/cgit/tree/README - Could we provide instructions to play nicely with gitolite? I assume the existing instructions are meant to work with plain repos or the git-daemon? If yes I could provide necessary steps for gitolite since this is what my journey was about. :) At least the existing instructions don't work nicely with gitolite. 2. Permissions If cache-size is enabled in "/etc/cgitrc" cgit requires write write permissions in "/var/cache/cgit". The default permissions after installation are "700 git:git". This is wrong in my opinion since user git was created by gitolite and not by cgit. That's it. I had more on my list, but I figured these just were based on lack of understanding how gitolite and cgit interact.
Created attachment 311167 [details] cgit-0.9.0.3.ebuild Updated ebuild for cgit-0.9.0.3.ebuild. Only renamed, obsolete xss patch removed, 2 new patches added for highlight (one to support highlight 3 since that's the default in tree, one to accommodate for errors in <highlight-3.5).
Created attachment 311169 [details, diff] use-highlight-version-3.patch Use highlight version 3 by default. Version 2 is no longer in tree.
Created attachment 311171 [details, diff] work-around-highlight-force-bug.patch Workaround for highlight version < 3.5, applied only if necessary. See http://hjemli.net/git/cgit/patch/?id=f50be7fda0a7ab57009169dd5905fcbab8eb5166
(In reply to comment #3) > Now here are some proposals. After all I'm not sure if those are fixable are > just a matter of configuration. Since I setup cgit for the first time and > I'm relatively new to git I might be wrong. > > 1. Postinstall instructions > - We should point to the README -> http://hjemli.net/git/cgit/tree/README > - Could we provide instructions to play nicely with gitolite? I assume the > existing instructions are meant to work with plain repos or the git-daemon? > If yes I could provide necessary steps for gitolite since this is what my > journey was about. :) At least the existing instructions don't work nicely > with gitolite. You can easily add an article there [1]. The maintainer can link to it in pkg_postinst. [1] http://wiki.gentoo.org/
Evidently these bugs are fixed in 0.9.1.
