Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 409379 - sys-kernel/tuxonice-sources-3.2.12 version bump
Summary: sys-kernel/tuxonice-sources-3.2.12 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2012-03-22 21:14 UTC by Kristian
Modified: 2012-07-22 12:03 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for tuxonice-sources-3.2.12 (tuxonice-sources-3.2.12.ebuild,1.63 KB, text/plain)
2012-03-22 21:15 UTC, Kristian
Details
tuxonice-sources-3.3.8.ebuild (tuxonice-sources-3.3.8.ebuild,1.08 KB, text/plain)
2012-07-15 06:56 UTC, Hypnos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian 2012-03-22 21:14:27 UTC
There has not been an official release of a tuxonice http://tuxonice.net/ patchset since kernel 3.0, nly the git tree from https://github.com/NigelCunningham?p=tuxonice-kernel.git;a=summary, which make it hard to package in ebuilds.

An unofficial patchset was posted on

http://crow202.org/tuxonice/

which seems to work, so I created an ebuild based on the latest gentoo-sources.

Reproducible: Always
Comment 1 Kristian 2012-03-22 21:15:47 UTC
Created attachment 306367 [details]
ebuild for tuxonice-sources-3.2.12
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-03-23 15:15:24 UTC
Comment on attachment 306367 [details]
ebuild for tuxonice-sources-3.2.12

--- tuxonice-sources-3.0.24.ebuild      2012-03-17 11:30:12.000000000 +0100
+++ -   2012-03-23 16:15:12.576991680 +0100
@@ -6,7 +6,7 @@
 
 ETYPE="sources"
 K_WANT_GENPATCHES="base extras"
-K_GENPATCHES_VER="21"
+K_GENPATCHES_VER="12"
 
 inherit kernel-2
 detect_version
@@ -16,17 +16,17 @@
 HOMEPAGE="http://dev.gentoo.org/~mpagano/genpatches/ http://www.tuxonice.net"
 IUSE=""
 
-TUXONICE_SNAPSHOT="20111012"
+TUXONICE_SNAPSHOT=""
 TUXONICE_VERSION=""
-TUXONICE_TARGET="3.0"
+TUXONICE_TARGET="3.2.10"
 
 # Because "current" patches can change without notifying, we need to supply them
 if [[ -n "${TUXONICE_SNAPSHOT}" ]]; then
        TUXONICE_SRC="http://dev.gentoo.org/~pacho/tuxonice/current-tuxonice-for-${TUXONICE_TARGET}_${TUXONICE_SNAPSHOT}.patch"
        UNIPATCH_LIST="${DISTDIR}/current-tuxonice-for-${TUXONICE_TARGET}_${TUXONICE_SNAPSHOT}.patch.bz2"
 else
-       TUXONICE_SRC="http://www.tuxonice.net/files/tuxonice-${TUXONICE_VERSION}-for-${TUXONICE_TARGET}.patch"
-       UNIPATCH_LIST="${DISTDIR}/tuxonice-${TUXONICE_VERSION}-for-${TUXONICE_TARGET}.patch.bz2"
+       TUXONICE_SRC="http://crow202.org/tuxonice/tuxonice-${TUXONICE_TARGET}.patch"
+       UNIPATCH_LIST="${DISTDIR}/tuxonice-${TUXONICE_TARGET}.patch.bz2"
 fi
 
 TUXONICE_URI="${TUXONICE_SRC}.bz2"
Comment 3 Pacho Ramos gentoo-dev 2012-03-23 18:56:04 UTC
I have mailed upstream about this unofficial patchset as I prefer to keep using official one as much as possible
Comment 4 Kristian 2012-03-23 21:26:12 UTC
Yeah, the problem seems to be known.
http://lists.tuxonice.net/pipermail/tuxonice-users/2012-January/001028.html

Upstream should also be aware of this patch, since I found it on the mailinglist.
http://lists.tuxonice.net/pipermail/tuxonice-users/2012-March/001050.html

Anyway, things are lagging behind
http://lists.tuxonice.net/pipermail/tuxonice-users/2012-January/001028.html

I hope we will get regular releases back.
Comment 5 Eitan Mosenkis 2012-04-17 13:52:13 UTC
It would appear that official releases are not forthcoming from upstream. As per the discussion in [1], could we start having snapshot-based ebuilds? The vanilla kernel is up to 3.3, gentoo sources are on 3.2, and tuxonice is still 3.0, which seems particularly silly because even for 3.0, the official download is just called current-for-3.0.

[1] http://lists.tuxonice.net/pipermail/tuxonice-users/2012-April/001062.html
Comment 6 Jan Psota 2012-05-05 18:27:01 UTC
What about removing tuxonice-sources from portage and suggest users to switch to pf-sources instead? I switched to pf- in 2010 and can say it was right. (I use it on servers, too)
Comment 7 Krzysztof Pawlik (RETIRED) gentoo-dev 2012-05-05 18:43:32 UTC
(In reply to comment #6)
> What about removing tuxonice-sources from portage and suggest users to
> switch to pf-sources instead?

You... know the difference, right?

> I switched to pf- in 2010 and can say it was right. (I use it on servers, too)

I didn't, I use hardened-sources on servers.

I agree with Pacho (see comment #3).
Comment 8 Hypnos 2012-07-15 06:56:10 UTC
Created attachment 318210 [details]
tuxonice-sources-3.3.8.ebuild

Upstream does tag a tuxonice-3.3 release here:

http://github.com/NigelCunningham/tuxonice-kernel/commit/759e62739ef570022e51d7777b8b01d37b0af707

The most recent release is gregkh's 3.3.8 release here:

http://github.com/NigelCunningham/tuxonice-kernel/commit/845720650c557a75262b629b0bc228fffcf64638

I'm attaching a sample ebuild that extracts this diff via GitHub's web interface.

The 3.4 series seems to be in progress:

http://github.com/NigelCunningham/tuxonice-kernel/commits/tuxonice-3.4

However, there don't seem to be any systematic tuxonice release tags vs. vanilla patch-level release tags.
Comment 9 Oliver Freyermuth 2012-07-17 11:26:14 UTC
Nigel Cunningham has released stable patchsets recently against 3.2, 3.3 and even 3.4: 
  http://lists.tuxonice.net/pipermail/tuxonice-users/2012-July/001106.html
However, the uploaded patchsets are named "latest-TuxOnIce-for-Linux-${KERNEL_VERSION}" and he promised to keep them up to date, which makes them unsuitable for ebuild-use. 

A more helpful patchset against 3.4 can also be generated from git and should be suitable for ebuild-use: 
https://github.com/NigelCunningham/tuxonice-kernel/compare/vanilla-3.4...tuxonice-3.4.patch
Comment 10 Eitan Mosenkis 2012-07-20 01:42:26 UTC
I've installed 3.3.8 using this ebuild and it's working quite well (x86_64). It would be great to have up-to-date tuxonice back in the tree.
Comment 11 Pacho Ramos gentoo-dev 2012-07-21 18:35:04 UTC
+*tuxonice-sources-3.3.8 (21 Jul 2012)
+*tuxonice-sources-3.4.5 (21 Jul 2012)
+*tuxonice-sources-3.2.21 (21 Jul 2012)
+
+  21 Jul 2012; Pacho Ramos <pacho@gentoo.org> +tuxonice-sources-3.2.21.ebuild,
+  +tuxonice-sources-3.3.8.ebuild, +tuxonice-sources-3.4.5.ebuild:
+  Version bump with support for 3.2, 3.3 and 3.4 kernels. Thanks a lot to people
+  in bug #409379 for keeping an eye on upstream updates.
+
Comment 12 Hypnos 2012-07-22 01:39:55 UTC
Great!

Does this mean that the kernel team is back on the tuxonice horse, or should the users continue to follow Nigel Cunningham's commits and file a bug when he tags a "release" ?
Comment 13 Hypnos 2012-07-22 07:43:49 UTC
pacho,

tuxonice-sources-3.3.8 did not build for me; here's the error:

--------------------------------------------------------------------

  CC      kernel/power/user.o
kernel/power/user.c: In function 'snapshot_ioctl':
kernel/power/user.c:226:3: error: implicit declaration of function 'usermodehelper_disable'
kernel/power/user.c:232:4: error: implicit declaration of function 'usermodehelper_enable'
make[2]: *** [kernel/power/user.o] Error 1
make[1]: *** [kernel/power] Error 2
make: *** [kernel] Error 2

--------------------------------------------------------------------

One difference between your patch and the patch extracted by my ebuild is that mine has a number of "#include <linux/kmod.h>" directives which yours does not; kmod.h has the declaration for usermodehelper_{enable,disable} .

Which ref are you comparing to 3.3.8 ?
Comment 14 Pacho Ramos gentoo-dev 2012-07-22 08:40:24 UTC
(In reply to comment #12)
> Great!
> 
> Does this mean that the kernel team is back on the tuxonice horse, or should
> the users continue to follow Nigel Cunningham's commits and file a bug when
> he tags a "release" ?

I will check for new TOI patches when genpatches versions are bumped

(In reply to comment #13)
> pacho,
> 
> tuxonice-sources-3.3.8 did not build for me; here's the error:
> 
> --------------------------------------------------------------------
> 
>   CC      kernel/power/user.o
> kernel/power/user.c: In function 'snapshot_ioctl':
> kernel/power/user.c:226:3: error: implicit declaration of function
> 'usermodehelper_disable'
> kernel/power/user.c:232:4: error: implicit declaration of function
> 'usermodehelper_enable'
> make[2]: *** [kernel/power/user.o] Error 1
> make[1]: *** [kernel/power] Error 2
> make: *** [kernel] Error 2
> 
> --------------------------------------------------------------------
> 
> One difference between your patch and the patch extracted by my ebuild is
> that mine has a number of "#include <linux/kmod.h>" directives which yours
> does not; kmod.h has the declaration for usermodehelper_{enable,disable} .
> 
> Which ref are you comparing to 3.3.8 ?

It comes from:
http://tuxonice.net/downloads/all/

-> http://tuxonice.net/downloads/all/latest-TuxOnIce-for-Linux-3.3.patch.bz2
Comment 15 Hypnos 2012-07-22 11:03:12 UTC
Thanks for your reply.

It's not clear to me what the value of those uploaded patches are.  The head of some x.y tuxonice branch is not guaranteed to work with any x.y.z upstream kernel.  The only combination that I think is reasonably guaranteed to work is a tuxonice "release" commit with the kernel version corresponding to the most recent upstream merge prior to the commit.  My ebuild for 3.3.8 employs this logic.
Comment 16 Pacho Ramos gentoo-dev 2012-07-22 11:16:00 UTC
I would prefer to use generated patches by Nigel instead, please open a bug report with your issue to report the problem to upstream mailing list. Also attach a diff between your working kernel and non working one to apply it until upstream patches are regenerated
Comment 17 Pacho Ramos gentoo-dev 2012-07-22 11:49:09 UTC
(In reply to comment #13)
> pacho,
> 
> tuxonice-sources-3.3.8 did not build for me; here's the error:
> 
> --------------------------------------------------------------------
> 
>   CC      kernel/power/user.o
> kernel/power/user.c: In function 'snapshot_ioctl':
> kernel/power/user.c:226:3: error: implicit declaration of function
> 'usermodehelper_disable'
> kernel/power/user.c:232:4: error: implicit declaration of function
> 'usermodehelper_enable'
> make[2]: *** [kernel/power/user.o] Error 1
> make[1]: *** [kernel/power] Error 2
> make: *** [kernel] Error 2
> 
> --------------------------------------------------------------------
> 
> One difference between your patch and the patch extracted by my ebuild is
> that mine has a number of "#include <linux/kmod.h>" directives which yours
> does not; kmod.h has the declaration for usermodehelper_{enable,disable} .
> 
> Which ref are you comparing to 3.3.8 ?

http://lists.tuxonice.net/pipermail/tuxonice-devel/2012-July/007270.html
Comment 18 Hypnos 2012-07-22 12:03:22 UTC
Thanks pacho.

Per your instructions, I opened bug #427628 .