Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 408107 - sys-block/tgt: add a conf.d/tgtd to allow optional TGTD_OPTS variable to init script
Summary: sys-block/tgt: add a conf.d/tgtd to allow optional TGTD_OPTS variable to init...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Cluster Team
URL: http://stgt.sf.net/
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-03-14 01:10 UTC by Christian Bricart
Modified: 2012-03-14 10:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch for $PORTDIR/sys-block/tgt/files/tgtd (tgtd-confd.patch,407 bytes, patch)
2012-03-14 01:12 UTC, Christian Bricart 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Bricart 2012-03-14 01:10:41 UTC 
the daemon tgtd actually has an option to bind the iscsi portal to a specific IP address rather than 0.0.0.0

This patch will introduce handling this option through a /etc/conf.d/tgtd, like:

 TGTD_OPTS="--iscsi portal=192.168.1.1:3260"

 or default:
 
 TGTD_OPTS=""

patch to current initd in $PORTDIR/sys-block/tgt/files/tgtd is trivial, but attached anyway


Reproducible: Always
Comment 1 Christian Bricart 2012-03-14 01:12:09 UTC 
Created attachment 305267 [details, diff]
patch for $PORTDIR/sys-block/tgt/files/tgtd
Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-03-14 10:07:40 UTC 
+*tgt-1.0.24-r1 (14 Mar 2012)
+
+  14 Mar 2012; Kacper Kowalik <xarthisius@gentoo.org> +files/tgtd-1.0.24.confd,
+  +files/tgtd-1.0.24.initd, +tgt-1.0.24-r1.ebuild, -tgt-1.0.24.ebuild:
+  Allow to pass options to daemon via confd file. Fixes 408107 bug by Christian
+  Bricart <christian@bricart.de> Improve sed to add LDFLAGS only where they're
+  needed, respect CC properly
+