407719 – app-emulation/vmware-modules-264.2 fails to apply 264.2-3.2.0.patch

Bug 407719 - app-emulation/vmware-modules-264.2 fails to apply 264.2-3.2.0.patch

Summary: app-emulation/vmware-modules-264.2 fails to apply 264.2-3.2.0.patch

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Vadim Kuznetsov (RETIRED)

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2012-03-10 21:23 UTC by Bartosz Brachaczek
Modified:	2012-03-13 21:56 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
fixed ebuild (vmware-modules-264.2.ebuild,1.90 KB, text/plain) 2012-03-11 09:29 UTC, Oliver Jaksch	Details
fixed patch (264-3.2.0.patch,2.88 KB, patch) 2012-03-11 09:30 UTC, Oliver Jaksch	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Bartosz Brachaczek 2012-03-10 21:23:51 UTC

app-emulation/vmware-modules-264.2 fails to apply 264.2-3.2.0.patch because such file does not exist. What does exist though is 264-3.2.0.patch but it fails to apply against this version of vmware-modules. Not applying 3.2.0 patch at all results in compilation errors on my 3.3.0-rc kernel (while previous vmware-modules version compiled fine with that kernel). So I guess that a new patch is needed and someone simply forgot to upload it.

 * Messages for package app-emulation/vmware-modules-264.2:

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 * 
 *   /usr/portage/app-emulation/vmware-modules/files/264.2-3.2.0.patch
 *   ( 264.2-3.2.0.patch )
 * ERROR: app-emulation/vmware-modules-264.2 failed (prepare phase):
 *   Cannot find $EPATCH_SOURCE!
 * 
 * Call stack:
 *     ebuild.sh, line   85:  Called src_prepare
 *   environment, line 3239:  Called epatch '/usr/portage/app-emulation/vmware-modules/files/264.2-3.2.0.patch'
 *   environment, line 1127:  Called die
 * The specific snippet of code:
 *                   die "Cannot find \$EPATCH_SOURCE!";

Comment 1 Oliver Jaksch 2012-03-11 09:29:31 UTC

Created attachment 304899 [details]
fixed ebuild

This one was easy:
- epatch "${FILESDIR}/${PV}-3.2.0.patch" should be
  epatch "${FILESDIR}/${PV_MAJOR}-3.2.0.patch" because of naming convention
- removed the first block 'vmmon-only/linux/iommu.c' of the patch in '264-3.2.0.patch' as there aren't any iommu files in vmmon-only anymore...already fixed by VMware?

With these corrections app-emulation/vmware-modules-264.2 compiles fine. No further testing done yet.

Comment 2 Oliver Jaksch 2012-03-11 09:30:01 UTC

Created attachment 304901 [details, diff]
fixed patch

Comment 3 urcindalo 2012-03-11 17:50:02 UTC

Same failure here on amd64.

Comment 4 zasire 2012-03-11 20:00:28 UTC

Same failure on my system (amd64). Fixed ebuild and patch did it.

Comment 5 Lori 2012-03-12 09:53:23 UTC

(In reply to comment #4)
> Same failure on my system (amd64). Fixed ebuild and patch did it.

+1

Should go to the tree.

Comment 6 Jeroen Roovers (RETIRED) gentoo-dev

2012-03-13 21:37:19 UTC

Comment on attachment 304899 [details]
fixed ebuild

--- vmware-modules-264.2.ebuild 2012-03-10 15:17:50.000000000 +0100
+++ -   2012-03-13 22:37:05.792532709 +0100
@@ -63,7 +63,7 @@
        epatch "${FILESDIR}/${PV_MAJOR}-makefile-include.patch"
        epatch "${FILESDIR}/${PV_MAJOR}-jobserver.patch"
        epatch "${FILESDIR}/${PV_MAJOR}-netdevice.patch"
-       epatch "${FILESDIR}/${PV}-3.2.0.patch"
+       epatch "${FILESDIR}/${PV_MAJOR}-3.2.0.patch"
 }
 
 src_install() {

Comment 7 Vadim Kuznetsov (RETIRED) gentoo-dev

2012-03-13 21:56:37 UTC

Sorry, I forgot to commit the patch when I moved it from overlay. I fixed that.  

12 Mar 2012; Vadim Kuznetsov <vadimk@gentoo.org> +files/264.2-3.2.0.patch:
  missing patch