Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 407523 - qt4-build.eclass need update for qt-4.8
Summary: qt4-build.eclass need update for qt-4.8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: InVCS, REVIEWED
Depends on:
Blocks:
 
Reported: 2012-03-09 13:48 UTC by MATSUI Tetsushi
Modified: 2012-04-04 16:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff against eclass (qt4-build.eclass.diff,2.42 KB, text/plain)
2012-03-09 13:48 UTC, MATSUI Tetsushi
Details
revised patch (qt4-build.eclass.diff,2.41 KB, patch)
2012-03-30 16:52 UTC, MATSUI Tetsushi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MATSUI Tetsushi 2012-03-09 13:48:11 UTC
Created attachment 304727 [details]
diff against eclass

qt4-build.eclass need update for qt-4.8 for OS X, since a config file name is changed.

In the eclass, sed fails with "no such file or directory" when trying to configure qt-core-4.8.0-r1. The file mkspecs/common/mac-g++.conf has been renamed to mkspecs/common/g++-macx.conf.

The attached diff is my attempt to make the eclass work both with 4.7.x and 4.8.x.  I can emerge 4.8 version of qt-core or qt-gui with the modified eclass.
Comment 1 Fabian Groffen gentoo-dev 2012-03-24 16:28:40 UTC
@qt, MATSUI's patch only touches the Darwin conditional parts.  I believe you work in your overlay first.  Would you mind applying MATSUI's patch, so it can get in gx86 at your next push?
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2012-03-24 17:22:19 UTC
+	elif [ -f mkspecs/common/g++-base.conf ]; then
+		# qt >= 4.8 has g++-macx.conf
+		macgppconf="mkspecs/common/g++-macx.conf"

You said the new filename is g++-macx.conf but the conditional looks for g++-base.conf... typo?

Also, use bash-style (double brackets) conditionals everywhere please.


+	macgccconfs="${macgccconf} mkspecs/common/gcc-base-macx.conf"

macgccconf should be macgccconfs I suppose (note the final 's'). Anyway, just use += to avoid the issue altogether.
Comment 3 MATSUI Tetsushi 2012-03-30 16:52:51 UTC
Created attachment 307219 [details, diff]
revised patch

Thank you for the review. The patch is revised on your comments.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-03-30 21:47:08 UTC
Patch looks good
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2012-03-31 12:23:37 UTC
Patch applied to the qt overlay, will be moved to gentoo-x86 later. Thanks!
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2012-04-04 16:40:14 UTC
(In reply to comment #5)
> Patch applied to the qt overlay, will be moved to gentoo-x86 later. Thanks!

All done, thanks for the patch!