Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 406111 - app-office/libreoffice: generate_libreoffice_package.sh should set safe CFLAGS/CXXFLAGS
Summary: app-office/libreoffice: generate_libreoffice_package.sh should set safe CFLAG...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 07:51 UTC by Pacho Ramos
Modified: 2012-05-27 15:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-02-28 07:51:27 UTC
As reported in bug 403915 it should set:
- x86: -march=i686 -mtune=generic -O2 -pipe
- amd64: -march=x86-64 -mtune=generic -O2 -pipe

Thanks
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2012-02-28 08:29:56 UTC
Patches welcome.

Matt might have already something handy.
Comment 2 Pacho Ramos gentoo-dev 2012-02-28 08:32:28 UTC
Well, I didn't contribute patches because I am unsure about how to check we want to compile x86 or amd64 binpkgs :-/
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2012-05-26 21:51:18 UTC
I guess we can close this now.
Comment 4 Pacho Ramos gentoo-dev 2012-05-27 08:39:18 UTC
How was this CFLAGS issue solved finally? Thanks for the info :)
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2012-05-27 10:10:03 UTC
(In reply to comment #4)
> How was this CFLAGS issue solved finally? Thanks for the info :)

I dont know exactly how Matthew Summers solved it for the packages he generated, but I use two chroots for amd64 and x86 libreoffice-bin, and just set the -march parameter to the smallest common denominator for the entire chroot now. 

CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -g"
or
CFLAGS="-march=i586 -mtune=generic -O2 -pipe -g"
Comment 6 Pacho Ramos gentoo-dev 2012-05-27 10:19:27 UTC
OK, do you mind adding a commented note in script to tell people to set proper CFLAGS when running it?
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2012-05-27 13:00:07 UTC
(In reply to comment #6)
> OK, do you mind adding a commented note in script to tell people to set
> proper CFLAGS when running it?

Can do, but since it's not stored at any centralized place... 

(A git repo for a single file does not make too much sense.)
Comment 8 Pacho Ramos gentoo-dev 2012-05-27 13:22:23 UTC
Well, showing an "echo" with this information in generate_libreoffice_package.sh script would be enough
Comment 9 Matt Summers (RETIRED) gentoo-dev 2012-05-27 15:22:09 UTC
Those are the CFLAGS I used, in Comment 5. I only build for 64bit though. I thought the script was in the files dir for libreoffice, no?
Comment 10 Andreas K. Hüttel archtester gentoo-dev 2012-05-27 15:31:20 UTC
(In reply to comment #9)
> I
> thought the script was in the files dir for libreoffice, no?

Doh, I did not know that. I've updated it with my newest version, and left a comment in there about the required CFLAGS.
Comment 11 Pacho Ramos gentoo-dev 2012-05-27 15:59:40 UTC
Thanks! :D