Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 40562 - Convenience wrapper for lilo-22.5.8
Summary: Convenience wrapper for lilo-22.5.8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on: 23246
Blocks:
  Show dependency tree
 
Reported: 2004-02-06 00:20 UTC by Tony Vroon (RETIRED)
Modified: 2004-06-09 09:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lilo-22.5.8-r1.ebuild.diff (lilo-22.5.8-r1.ebuild.diff,1.57 KB, patch)
2004-02-06 00:21 UTC, Tony Vroon (RETIRED)
Details | Diff
dolilo (dolilo,45 bytes, text/plain)
2004-02-06 00:21 UTC, Tony Vroon (RETIRED)
Details
lilo-22.5.8-animated-menu.patch (lilo-22.5.8-animated-menu.patch,28.73 KB, patch)
2004-02-06 00:22 UTC, Tony Vroon (RETIRED)
Details | Diff
dolilo (dolilo,1.34 KB, text/plain)
2004-02-06 00:25 UTC, Tony Vroon (RETIRED)
Details
dolilo wrapper script (dolilo,39 bytes, text/plain)
2004-02-06 00:33 UTC, Tony Vroon (RETIRED)
Details
dolilo (dolilo,1.46 KB, text/plain)
2004-02-06 00:35 UTC, Tony Vroon (RETIRED)
Details
dolilo deluxe (dolilo,3.88 KB, text/plain)
2004-02-06 18:30 UTC, Tony Vroon (RETIRED)
Details
dolilo genkernel edition (dolilo,4.13 KB, text/plain)
2004-02-08 08:56 UTC, Tony Vroon (RETIRED)
Details
dolilo genkernel+bootsplash (dolilo,4.42 KB, text/plain)
2004-02-08 12:42 UTC, Tony Vroon (RETIRED)
Details
dolilo livecd,genkernel,bootsplash (dolilo,5.43 KB, text/plain)
2004-02-08 19:07 UTC, Tony Vroon (RETIRED)
Details
lilo-22.5.8-r1.ebuild.diff (lilo-22.5.8-r1.ebuild.diff,3.93 KB, patch)
2004-02-09 10:24 UTC, Tony Vroon (RETIRED)
Details | Diff
lilo-22.5.8-r1.ebuild.diff (lilo-22.5.8-r1.ebuild.diff,1.73 KB, patch)
2004-02-17 14:48 UTC, Tony Vroon (RETIRED)
Details | Diff
dolilo (dolilo,5.35 KB, text/plain)
2004-02-23 07:43 UTC, Tony Vroon (RETIRED)
Details
dolilo koutput+bootsplash (dolilo,7.61 KB, text/plain)
2004-03-24 12:29 UTC, Tony Vroon (RETIRED)
Details
dolilo dynamic koutput edition (dolilo,8.54 KB, text/plain)
2004-03-26 09:11 UTC, Tony Vroon (RETIRED)
Details
dolilo release candidate 1 (dolilo,8.49 KB, text/plain)
2004-03-26 09:50 UTC, Tony Vroon (RETIRED)
Details
dolilo release candidate 2 (dolilo,8.54 KB, text/plain)
2004-03-26 10:18 UTC, Tony Vroon (RETIRED)
Details
dolilo memtest86 edition (dolilo,9.46 KB, text/plain)
2004-04-04 07:06 UTC, Tony Vroon (RETIRED)
Details
dolilo with better bootsplash support (dolilo,10.00 KB, text/plain)
2004-04-14 10:12 UTC, Tony Vroon (RETIRED)
Details
dolilo 2004.0 LiveCD compatible (dolilo,10.04 KB, text/plain)
2004-04-25 10:42 UTC, Tony Vroon (RETIRED)
Details
lilo-22.5.8-r2.ebuild.diff (lilo-22.5.8-r2.ebuild.diff,1.88 KB, text/plain)
2004-04-25 10:49 UTC, Tony Vroon (RETIRED)
Details
dolilo with full genkernel & conf.d/dolilo support (dolilo,11.13 KB, text/plain)
2004-05-11 09:27 UTC, Tony Vroon (RETIRED)
Details
/etc/conf.d/dolilo (dolilo.conf.d,982 bytes, text/plain)
2004-05-11 09:29 UTC, Tony Vroon (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:20:46 UTC
The Makefile has changed, causing the animated-menus patch to no longer apply. New patch made and attached.
Besides that, ebuild changes:
- tell about dolilo
- do not set S, as ${WORKDIR}/${P} is the default (ebuild mistakes doc)
- fix typo "is" -> "are", there are multiple .b's in /boot
- apply the animated menu's patch again

Dolilo is a convenience wrapper that mounts /boot (remounts it rw when it's 
mounted ro), runs /sbin/lilo and then restores the original situation (this might mean
unmounting /boot if it wasn't mounted, or remounting it ro).
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:21:12 UTC
Created attachment 25058 [details, diff]
lilo-22.5.8-r1.ebuild.diff
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:21:42 UTC
Created attachment 25059 [details]
dolilo

dolilo wrapper script
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:22:25 UTC
Created attachment 25060 [details, diff]
lilo-22.5.8-animated-menu.patch
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:24:49 UTC
Comment on attachment 25059 [details]
dolilo

Defective file, upload error.
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:25:21 UTC
Created attachment 25061 [details]
dolilo
Comment 6 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:33:40 UTC
Created attachment 25062 [details]
dolilo wrapper script

Forgot the Gentoo copyright header, added.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 00:35:36 UTC
Created attachment 25063 [details]
dolilo

Upload failed again, apparently. Retrying.
Comment 8 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 18:30:38 UTC
Created attachment 25114 [details]
dolilo deluxe

Did some extra work on the wrapper.
This makes using lilo as your bootloader a fairly easy task, even when you're
completely new to this.

I have a separate /boot partition, I just compiled a kernel in /usr/src/linux,
and I don't have an /etc/lilo.conf file yet (this has sanity checks in case the
way I determine the boot-device doesn't work out):

prometheus / # dolilo
A minimal /etc/lilo.conf has been generated for you as you didn't have one yet.
Your kernel image has been copied to /boot/bzImage.
Added linux *

Ofcourse, it doesn't replace lilo, so you never run this by accident.
Comment 9 Tony Vroon (RETIRED) gentoo-dev 2004-02-06 18:40:45 UTC
This extension to dolilo was just a random idea that worked really well, btw.

If you still want the ebuild to handle things automatically, you might want to consider calling /sbin/dolilo instead, as this also fixes bug 23246
Comment 10 Martin Schlemmer (RETIRED) gentoo-dev 2004-02-08 07:30:14 UTC
The old ani-menu patch broke the timeout option - is this still the case?

As for the wrapper - could work for use in the eclass, but it will not
fix it for grub, elilo, etc.  I think rather then if that bug is high priority,
then we should rather fix the eclass.
Comment 11 Tony Vroon (RETIRED) gentoo-dev 2004-02-08 08:56:32 UTC
Created attachment 25194 [details]
dolilo genkernel edition

This version of dolilo can deal with a genkernel-built kernel.
I'll go and test how the timeout is doing.
Comment 12 Tony Vroon (RETIRED) gentoo-dev 2004-02-08 12:42:12 UTC
Created attachment 25208 [details]
dolilo genkernel+bootsplash

This version of dolilo is also capable of placing an initrd in boot, for
bootsplash support. 
Besides that, I apologize for two things, for not checking the graphical bootup
more thoroughly (you were right, the timeout doesn't work anymore). Besides
that, #!/bin/bash was missing, to used to working in ebuild files.

This one is syntactically correct, and might be usable for grub as well, but
since I don't use that, I have no way to tell.
I will e-mail the person that forward ported this patch, to see if there is a
solution for this. If you would be willing to include dolilo in the tree, that
would be very nice (makes lilo a lot easier to use).
In the meantime, feel free to RESO NEEDINFO for the animated-menu part of this.
I understand why I can't be enabled in it's current state.
Comment 13 Tony Vroon (RETIRED) gentoo-dev 2004-02-08 19:07:31 UTC
Created attachment 25228 [details]
dolilo livecd,genkernel,bootsplash

Found a way to confuse the script, causing an invalid /etc/lilo.conf to be
written. Patched. Lilo run is now invisible unless errors are reported.
Bootsplash support is extended and writes out the necessary append= and vga=
lines as well. It can also deal with being run from a LiveCD (different
$bootdev
and $rootdev lookup).
When called from the ebuild instead of the eclass, the handbook entry for using
lilo would become
"1) emerge lilo 2) doublecheck created configuration 3) you're done".

Example output, no /etc/lilo.conf, nothing in /boot (and it's not mounted):
voyager / # dolilo
Kernel image moved into place as /boot/bzImage.
Bootsplash initrd for 1024x768 resolution copied to /boot/initrd.
Adding bootsplash configuration to lilo.conf (video mode 791 for 1024x768
resolution).
A minimal /etc/lilo.conf has been generated for you as you didn't have one yet.
Bootsector updated succesfully.

No response from the patch author, will keep you posted.
Comment 14 Tony Vroon (RETIRED) gentoo-dev 2004-02-09 09:43:35 UTC
Comment on attachment 25060 [details, diff]
lilo-22.5.8-animated-menu.patch

Patch author has responded, and is unable to fix this. He is open to
suggestions, but I can't give any. Consider this a request for just dolilo from
now on.
Comment 15 Tony Vroon (RETIRED) gentoo-dev 2004-02-09 10:24:25 UTC
Created attachment 25271 [details, diff]
lilo-22.5.8-r1.ebuild.diff

This removes the mounting of /boot and the running of /sbin/lilo from the
ebuild and lets /sbin/dolilo do that.
It also mentions why the animated-menus patch is actually disabled (in the hope
that it saves people wasted time).
Comment 16 Martin Schlemmer (RETIRED) gentoo-dev 2004-02-15 12:26:55 UTC
I have a few issues with changing the ebuild:
1) It does not check if lilo is the current bootloader - meaning it can
   remove a working grub/whatever setup
2) It will break stage creation where $ROOT != "/".
Comment 17 Tony Vroon (RETIRED) gentoo-dev 2004-02-17 14:48:37 UTC
Created attachment 25802 [details, diff]
lilo-22.5.8-r1.ebuild.diff

Less intrusive changes in the ebuild this time (because I understand why those
checks are there now).
Just removed the mount-boot eclass usage as dolilo can handle this.
When /sbin/lilo would be called, dolilo is called instead. postinst tells the
user about dolilo.
Comment 18 Tony Vroon (RETIRED) gentoo-dev 2004-02-23 07:43:00 UTC
Created attachment 26162 [details]
dolilo

After testing things with an actual lilo-user who has using a LiveCD to install
(they're rare), I've made a few extra bugfixes, and removed a chunk of
LiveCD-specific code that proved to be unnecessary.
Determining of the kernel-version has also been reworked, it's better to check
where /usr/src/linux points to then just using uname (it breaks with the
LiveCD).
Comment 19 Tony Vroon (RETIRED) gentoo-dev 2004-03-24 12:29:22 UTC
Created attachment 27948 [details]
dolilo koutput+bootsplash

By latexer's request, dolilo is now KBUILD_OUTPUT aware for locating it's new
images. The error messages have been improved, and also the normal messages
that are emitted are a bit more clear. The configuration file is shorter
because most options are now specified globally.
Please test and tell me if you manage to confuse or break it.
Comment 20 Tony Vroon (RETIRED) gentoo-dev 2004-03-26 09:11:58 UTC
Created attachment 28070 [details]
dolilo dynamic koutput edition

Update from latexer regarding the KOUTPUT_BUILD specification in the Makefile,
it's more dynamic then I anticipated. With extra parsing to get it right, and I
had one bug, forgot to change a static kernel image path to ${KIMAGE}.
How's this?
Comment 21 Tony Vroon (RETIRED) gentoo-dev 2004-03-26 09:50:32 UTC
Created attachment 28074 [details]
dolilo release candidate 1

Two more bugs, forgotten " in error messages, add an extra line of verbosity
with regard to kernel image location, and fix KV. Deducting the kernel version
from the symlink is not portable (kernel makefile changes etc).
I promise to leave it alone for now, I can't find anything left that's awry,
and latexer had a quick peek as well.
Comment 22 Tony Vroon (RETIRED) gentoo-dev 2004-03-26 10:18:48 UTC
Created attachment 28079 [details]
dolilo release candidate 2

It was too easy to catch this one off-guard, the error message "dolilo is not
working out on your system" triggered in wrong circumstances. Better
if-statement protecting that.
Noted by Broekie, we display 6 values in the debug "not working out" print, not
4.
Comment 23 Tony Vroon (RETIRED) gentoo-dev 2004-04-04 07:06:43 UTC
Created attachment 28688 [details]
dolilo memtest86 edition

Since everyone is leaving this by the side of the road, I'm going to touch it
some more...
The name of backups made is now mentioned to the user. Backups are now made by
calling cp with appropriate options instead of mv'ing files (which could cause
an error message in some situations). Initial ramdisks are now also backupped.
"Mega if-monstrosities" are now separated out better, this should solve the
last logic bug, and bail out on errors earlier. The /usr/src/linux symlink is
checked, because the script heavily depends on it's validity. initrd is no
longer specified as a global variable in lilo.conf, to allow for two kernel
configs with separate initrd's. The memtest86 binary image is detected and
placed into the initial config (prompting is not added for this, however).
Error messages should be more helpful and to the point. (I'm not getting much
comments here, but I have been able to get some testers)
Comment 24 Tony Vroon (RETIRED) gentoo-dev 2004-04-14 10:12:20 UTC
Created attachment 29258 [details]
dolilo with better bootsplash support

This version of dolilo always makes an entry for the backup kernels
that the script creates as to avoid nasty deadlocks. Besides that,
it understands bootsplash themes now, and places the right initrd into
/boot.
The ebuild diff has been obsoleted as lilo 22.5.8-r2 has been released
without this wrapper.
Comment 25 Tony Vroon (RETIRED) gentoo-dev 2004-04-25 10:42:57 UTC
Created attachment 30024 [details]
dolilo 2004.0 LiveCD compatible

This version has a slight update to the rootdev= line to be able to cope with
2004.0 LiveCD's.
I will post an updated ebuild diff soon.
Comment 26 Tony Vroon (RETIRED) gentoo-dev 2004-04-25 10:49:20 UTC
Created attachment 30026 [details]
lilo-22.5.8-r2.ebuild.diff

This diff will update the ebuild to install and tell about dolilo. It will also
run
instead of the normal lilo to avoid leaving /boot mounted. (This fixes the
linked bug)
Comment 27 Tony Vroon (RETIRED) gentoo-dev 2004-05-11 09:27:30 UTC
Created attachment 31187 [details]
dolilo with full genkernel & conf.d/dolilo support

This version is fully compatible with genkernel, and generates the needed
entries on the append-line now (real_root= etc). Done from a working lilo
config submitted by a genkernel user.
Besides that, dolilo now supports /etc/conf.d/dolilo, from which the needed
append-line and various other options are read. With REWRITE enabled, a new
config	file is written each time, to allow for full autoconfiguration.
Switching to and from genkernel is now fully painless.
Comment 28 Tony Vroon (RETIRED) gentoo-dev 2004-05-11 09:29:20 UTC
Created attachment 31188 [details]
/etc/conf.d/dolilo

This is the example /etc/conf.d/dolilo.
The script will move on without errors if the file does not exist, and use the
safe non-rewrite default (in that it only creates /etc/lilo.conf if it doesn't
exist and otherwise leaves it alone).
Comment 29 Tony Vroon (RETIRED) gentoo-dev 2004-06-09 09:51:52 UTC
Updated remark in ebuild about the animated splashscreens, hopefully to keep people from trying to port the patch (it will break the timeout, yes).
Dolilo is available in lilo-22.5.9 which is in CVS now and should appear in the tree soon.