Bug 405465 – devmanual default for src_install is incorrect as of EAPI=4

• Status: RESOLVED FIXED
• Product: Documentation

[Description Michael Orlitzky 2012-02-23 17:40:05 UTC]

The default shown is a no-op, i.e. 'return'. As of EAPI=4, we have in phase-helpers.sh,

_eapi4_src_install() {
	if [[ -f Makefile || -f GNUmakefile || -f makefile ]] ; then
		emake DESTDIR="${D}" install
	fi

	if ! declare -p DOCS &>/dev/null ; then
		local d
		for d in README* ChangeLog AUTHORS NEWS TODO CHANGES \
				THANKS BUGS FAQ CREDITS CHANGELOG ; do
			[[ -s "${d}" ]] && dodoc "${d}"
		done
	elif [[ $(declare -p DOCS) == "declare -a "* ]] ; then
		dodoc "${DOCS[@]}"
	else
		dodoc ${DOCS}
	fi
}

[Comment 1 Jeremy Olexa (darkside) (RETIRED) 2012-02-23 17:58:14 UTC]

It is listed here though: http://devmanual.gentoo.org/ebuild-writing/eapi/index.html

[Comment 2 Michael Orlitzky 2012-02-23 18:32:38 UTC]

(In reply to comment #1)
> It is listed here though:
> http://devmanual.gentoo.org/ebuild-writing/eapi/index.html

Well, yeah, and probably a number of other places that nobody will look for it =)

If you don't want to duplicate the code listing to avoid future inconsistency, then there should at least be a link on the src_install page to that section of the EAPI4 notes.

Right now, if I'm looking for the default src_install, I go to the devmanual, click "src_install", and am shown the (now incorrect) default. Mission accomplished, I go about my business, and probably introduce a bug.

[Comment 3 Markos Chandras (RETIRED) 2012-10-28 09:52:52 UTC]

Thanks. Fixed