Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 405351 - dev-libs/libzip-0.10-r1 fails tests
Summary: dev-libs/libzip-0.10-r1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 01:12 UTC by Patrick Lauer
Modified: 2012-05-21 09:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libzip-remove-fread.patch (libzip-remove-fread.patch,622 bytes, patch)
2012-05-08 20:57 UTC, Chris Reffett (RETIRED)
Details | Diff
libzip-fix-decrypt.patch (libzip-fix-amd64-decrypt.patch,936 bytes, patch)
2012-05-09 00:59 UTC, Chris Reffett (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2012-02-23 01:12:08 UTC
make[2]: Entering directory `/var/tmp/portage/dev-libs/libzip-0.10-r1/work/libzip-0.10/regress'
PASS: add_dir.test
PASS: add_from_buffer.test
PASS: add_from_file.test
PASS: add_from_filep.test
PASS: add_from_zip.test
PASS: encrypt.test
FAIL: fread.test
PASS: get_comment.test
PASS: name_locate.test
PASS: open_many_ok.test
PASS: open_new_but_exists.test
PASS: open_new_ok.test
PASS: open_nonarchive.test
PASS: open_nosuchfile.test
PASS: open_ok.test
PASS: set_comment_all.test
PASS: set_comment_localonly.test
PASS: set_comment_removeglobal.test
PASS: set_comment_revert.test
PASS: torrent-already.test
PASS: torrent-new.test
======================================
1 of 21 tests failed
Please report to libzip-discuss@nih.at
======================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/var/tmp/portage/dev-libs/libzip-0.10-r1/work/libzip-0.10/regress'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/var/tmp/portage/dev-libs/libzip-0.10-r1/work/libzip-0.10/regress'
make: *** [check-recursive] Error 1
 * ERROR: dev-libs/libzip-0.10-r1 failed (test phase):
 *   Make check failed. See above for details.

Portage 2.1.10.48 (default/linux/amd64/10.0/desktop/kde, gcc-4.5.3, glibc-2.14.1-r2, 3.2.1-gentoo-r1 x86_64)
=================================================================
System uname: Linux-3.2.1-gentoo-r1-x86_64-AMD_Phenom-tm-_9950_Quad-Core_Processor-with-gentoo-2.1
Timestamp of tree: Unknown
ccache version 3.1.7 [disabled]
app-shells/bash:          4.2_p20
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.5.4-r4, 2.6.7-r2, 2.7.2-r3, 3.1.4-r3, 3.2.2
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.7-r3
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.11.3
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.3-r2
sys-devel/gcc-config:     1.5-r2
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.2 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r2
Repositories: gentoo
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs buildpkg distlocks ebuild-locks fixlafiles news parallel-fetch protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch xattr"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alisp alsa amd64 aria assistant berkdb bluetooth branding bzip2 cairo cdda cdr cgi cli compat consolekit corefonts cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emacs emboss encode examples exif fam firefox flac fontconfig fortran gcj gd gdbm gdu geos gif gpm gtk iconv icu ipv6 ithreads jpeg kde kdrive kipi lcms ldap libnotify mad mmx mng modules mp3 mp4 mpeg mssql mudflap multilib mysql ncurses nls nptl nptlonly objc ocaml ogg opengl openmp pam pango pcre pdf perl phonon plasma png policykit ppds pppd pyqt4 python qt3support qt4 readline script sdl semantic-desktop session soundex spell sqlite sse sse2 ssl startup-notification svg sysfs tcpd threads tiff tk truetype udev unicode usb vorbis wxwidgets x264 xattr xcb xcomposite xinerama xml xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Chris Reffett (RETIRED) gentoo-dev Security 2012-02-23 15:27:30 UTC
Ran the test manually, I think this is the issue:
zeugma ~ # cd /var/tmp/portage/dev-libs/libzip-0.10-r1/work/libzip-0.10/regress/
zeugma regress # ./fread broken.zip
/var/tmp/portage/dev-libs/libzip-0.10-r1/work/libzip-0.10/regress/.libs/fread: cryptok: got zip_fopen error (Wrong password provided), expected no error (No error)
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2012-03-21 15:26:54 UTC
Tests passes in =dev-libs/libzip-0.10.1.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2012-03-22 07:26:57 UTC
I am still experiencing the same issue as described in comment #0 and comment #1 with libzip-0.10.1
Comment 4 Johannes Huber (RETIRED) gentoo-dev 2012-03-22 08:41:29 UTC
(In reply to comment #3)
> I am still experiencing the same issue as described in comment #0 and
> comment #1 with libzip-0.10.1

OK, reopened. Passes on x86 for me.
Comment 5 Chris Reffett (RETIRED) gentoo-dev Security 2012-05-08 20:57:01 UTC
Created attachment 311199 [details, diff]
libzip-remove-fread.patch

Fails for me as well, I've included a patch that removes the test.
Comment 6 Chris Reffett (RETIRED) gentoo-dev Security 2012-05-09 00:59:09 UTC
Created attachment 311215 [details, diff]
libzip-fix-decrypt.patch

So I did some searching on the issue, and it turns out the issue wasn't happening for johu is because (I think) he's running x86. Apparently libzip calls a function involving from zlib which changed in zlib 1.2.6 in such a way that it would behave differently for 32-bit versus 64-bit systems, and this somehow filters down to the failing test. Upstream is aware of the issue, and it's been committed in their version control system, but no word of backporting the fix to 0.10.1. I've attached a patch mentioned in their mailing list archives that fixes the CRC issue, all tests pass for me when this is applied.
Comment 7 Chris Reffett (RETIRED) gentoo-dev Security 2012-05-09 16:25:09 UTC
+  09 May 2012; Chris Reffett <creffett@gentoo.org> +libzip-0.10.1-r1.ebuild,
+  +files/libzip-0.10.1-fix_decrypt.patch:
+  Revision bump, added patch to fix CRC calls

Should be fixed now, reopen if there are any further issues.