Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 404429 - dev-python/html5lib-0.95 version bump request
Summary: dev-python/html5lib-0.95 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-18 17:59 UTC by Ian Delaney (RETIRED)
Modified: 2012-05-19 21:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (html5lib.patch,1.24 KB, patch)
2012-05-06 18:48 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2012-02-18 17:59:32 UTC
note.

SRC_URI="http://${PN}.googlecode.com/files/${P}.tar.gz mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"

archtester html5lib # ebuild html5lib-0.95.ebuild test merge

>>> /usr/share/doc/html5lib-0.95/README.bz2
 * Compilation and optimization of Python modules for CPython 2.7 ...                                    [ ok ]
>>> dev-python/html5lib-0.95 merged.

good to go
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2012-03-01 16:30:13 UTC
With the below patch, this fails rather a lot of tests for me.

--- html5lib-0.90.ebuild        2011-03-06 16:59:02.000000000 +0100
+++ html5lib-0.95.ebuild        2012-03-01 17:27:46.000000000 +0100
@@ -7,20 +7,20 @@
 PYTHON_USE_WITH="xml"
 SUPPORT_PYTHON_ABIS="1"
 RESTRICT_PYTHON_ABIS="3.*"
+DISTUTILS_SRC_TEST="nosetests"

 inherit distutils

 DESCRIPTION="HTML parser based on the HTML5 specification"
 HOMEPAGE="http://code.google.com/p/html5lib/ http://pypi.python.org/pypi/html5lib"
-SRC_URI="http://${PN}.googlecode.com/files/${P}.zip"
+SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"

 LICENSE="MIT"
 SLOT="0"
 KEYWORDS="amd64 x86 ~x86-fbsd"
 IUSE="examples"

-DEPEND="app-arch/unzip
-       dev-python/setuptools"
+DEPEND="dev-python/setuptools"
 RDEPEND=""

 src_install() {

I think some of this might have to do with chardet and/or lxml being installed.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2012-03-16 19:41:08 UTC
I tried it again; the test suite I can't get to work

gentoo64 html5lib-0.95-2.7 # python2.6 html5lib/tests/runtests.py

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
Use of nosetests pulls 85 errors consistently.  RESTRICT="test"
Comment 3 Mike Gilbert gentoo-dev 2012-04-23 15:22:05 UTC
(In reply to comment #1)
> I think some of this might have to do with chardet and/or lxml being
> installed.

Indeed.

With both chardet and lxml installed, I get 7988 errors, 35 failures.
Without chardet, I get 0 errors, 85 failures.
Without chardet and lxml 2 errors, 12 failures.

It seems like a very poor codebase or test suite.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2012-05-06 18:48:45 UTC
Created attachment 311027 [details, diff]
ebuild patch

http://code.google.com/p/html5lib/issues/detail?id=201&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary%20Port

The reading of the issues makes for sad viewing.  
-- The issues are reported in reverse chronological order.
-- The only issues reviewed and dealt with are those submitted by the project members themselves.
--  The last example of just that was May 1st. making reference to "we don't handle the case where we get given a file-like object that returns Unicode strings." which is consistent with this mass failure rate.

Perhaps it's reasonable in this case to do as I have in this patch
This version has been out for months.
Comment 5 Mike Gilbert gentoo-dev 2012-05-06 21:34:48 UTC
The bug you filed upstream is very hard to follow.

Some tips:

- Try not to list Gentoo-specific commands in upstream bug reports.
- Explain the symptoms concisely, in complete English sentences.
Comment 6 Mike Gilbert gentoo-dev 2012-05-06 21:50:12 UTC
(In reply to comment #3)
> It seems like a very poor codebase or test suite.

Forget I said this please. The 7988 errors are what caused me to say that, but that appear to be caused by a warning that chardet is producing:

UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
Comment 7 Mike Gilbert gentoo-dev 2012-05-19 21:46:07 UTC
I just bumped this with the tests disabled. Thanks for trying.