Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 404061 - app-portage/repoman: repoman should disallow broken SRC_URI protocols
Summary: app-portage/repoman: repoman should disallow broken SRC_URI protocols
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 08:20 UTC by Patrick Lauer
Modified: 2022-07-12 03:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2012-02-16 08:20:15 UTC
After having committed Mr_Bones_ notified me that I made a mistake:

dev-lang/rakudo-2011.04: file rakudo-2011.04.tar.gz: bad protocol/uri: ('github://rakudo/rakudo/rakudo-2011.04.tar.gz',)

So what happened was that the URLs were all http://github.com/download/...

Now repoman commit aborts on those, so I accidentally changed the URI to github:// instead of mirror://github

Repoman should catch such malformed SRC_URIs and not allow me to do such stupid things :)
Comment 1 Zac Medico gentoo-dev 2012-02-16 15:19:38 UTC
It seems like we'd have to maintain a whitelist of allowed protocols somewhere. I suppose we could have the repository provide the whitelist so that it's extensible.
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2017-03-16 01:09:28 UTC
Yes, this will have to wait for the stage 3 of the repoman rewrite to have this configuration data in the repository.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:37 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.