Bug 403999 – lxde-base/lxdm-0.4.1-r3 USE=pam has incomplete C defines

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Simon Poirier 2012-02-16 03:10:48 UTC]

emerging lxde-base/lxdm-0.4.1-r3 with USE=pam checks incorrect #define preprocessor macro which effectively disables PAM support.

Reproducible: Always

Steps to Reproduce:
1. USE=pam emerge lxdm
2. ldd /usr/sbin/lxdm-binary
Actual Results:  
pam features are disabled in lxdm.c
libpam is not linked in lxdm-binary

Expected Results:  
linked against libpam, using pam for authentication

This seems fixed in lxdm master branch, but last release is 0.4.1 which has the bug

[Comment 1 Simon Poirier 2012-02-16 03:18:38 UTC]

Created attachment 302105 [details, diff]
a fix

here's a short patch which to fix the issue. tested it with lxde-base/lxdm-0.4.1-r3

[Comment 2 Markos Chandras (RETIRED) 2012-02-16 08:35:32 UTC]

*** Bug 403529 has been marked as a duplicate of this bug. ***

[Comment 3 Markos Chandras (RETIRED) 2012-02-16 08:36:17 UTC]

Could you send this patch upstream?

[Comment 4 Simon Poirier 2012-02-16 13:13:26 UTC]

(In reply to comment #3)
> Could you send this patch upstream?

I see there has been a similar fix in the upstream git dating 2012-01-01 but
there has been no release since 0.4.1

check commit 0f9e8e53a8d30f5c8ccfb03edc282148f58bfd30 

or in gitweb
http://lxde.git.sourceforge.net/git/gitweb.cgi?p=lxde/lxdm;a=commit;h=0f9e8e53a8d30f5c8ccfb03edc282148f58bfd30

[Comment 5 Markos Chandras (RETIRED) 2012-02-18 11:41:34 UTC]

Thanks a lot. Fixed in -r4