Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 402769 - sys-block/nbd - nbd-server's "includedir" config setting fails silently on XFS
Summary: sys-block/nbd - nbd-server's "includedir" config setting fails silently on XFS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 20:31 UTC by Aljoscha Vollmerhaus
Modified: 2012-08-18 04:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aljoscha Vollmerhaus 2012-02-08 20:31:42 UTC
When you specify the "includedir" option in the [generic] section of your nbd-server config, it ignores every file within that directory because it distinguishes between files and other stuff using d_type and XFS does not support this.

Reproducible: Always

Steps to Reproduce:
1. Use XFS as your FS (at least where nbd-server searches for configs to include)
2. Specify "includedir = /path/to/some/dir" in the "[generic]" section
3. Place some config files in that directory, pay attention to the filename as nbd-server wants them to end with ".conf".
4. nbd-server says "no exports specified" and quits because it does not read any file in the "includedir" directory.
Actual Results:  
nbd-server fails to read parts of it´s config because XFS doesn´t support d_type, returning DT_UNKNOWN, causing nbd-server to ignore the .conf files.

Expected Results:  
nbd-server should read it´s config regardless of filesystem type.
Comment 1 Aljoscha Vollmerhaus 2012-02-08 20:34:13 UTC
Oh sorry i forgot - tested with sys-apps/nbd 2.9.22 and 2.9.25
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-02-09 00:48:03 UTC
Please post your `emerge --info sys-block/nbd' output in a comment.
Comment 3 Aljoscha Vollmerhaus 2012-02-09 01:55:16 UTC
netboot-keller ~ # emerge --info sys-block/nbd
Portage 2.1.10.44 (default/linux/amd64/10.0/no-multilib, gcc-4.5.3, glibc-2.13-r4, 3.2.1-gentoo-r2 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.2.1-gentoo-r2-x86_64-QEMU_Virtual_CPU_version_0.15.1-with-gentoo-2.0.3
Timestamp of tree: Tue, 07 Feb 2012 23:15:01 +0000
app-shells/bash:          4.1_p9
dev-lang/python:          2.7.2-r3, 3.1.4-r3
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 3.1 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe "
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe "
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ "
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="amd64 bash-completion berkdb bzip2 cli cracklib crypt cxx dri fam fortran gdbm gnutls iconv mmx modules mudflap ncurses nls nptl nptlonly offensive openmp pam pcre pppd readline session sse sse2 ssl ssse3 sysfs tcpd threads unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

sys-block/nbd-2.9.22 was built with the following:
USE=""
Comment 4 Aljoscha Vollmerhaus 2012-02-09 01:56:30 UTC
Here is a good example illustrating the d_type issue nbd is hitting with XFS:
http://nerdfortress.com/2008/09/19/linux-xfs-does-not-support-direntd_type/
Comment 5 SpanKY gentoo-dev 2012-08-18 04:00:25 UTC
this was fixed in the 3.1 release

commit 59437f4a1d85d6d36f3528cec54a6bf8d164fad4
Author: Wouter Verhelst <w@uter.be>
Date:   Thu Feb 23 08:57:41 2012 +0100

    Support filesystems that don't return filetypes in readdir()

...
        switch(de->d_type) {
+           case DT_UNKNOWN:
+               /* Filesystem doesn't return type of
+                * file through readdir. Run stat() on
+                * the file instead */
...