Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 401173 - x11-libs/qt-assistant: Fix automagic dependency on x11-libs/qt-webkit
Summary: x11-libs/qt-assistant: Fix automagic dependency on x11-libs/qt-webkit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH, REVIEWED, TESTED
Depends on:
Blocks:
 
Reported: 2012-01-28 12:21 UTC by Markos Chandras (RETIRED)
Modified: 2012-01-29 19:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qt-assistant-4.8.0::qting-edge build log (1327764512-install-x11-libs_qt-assistant-4.8.0:4::qting-edge.out,332.48 KB, text/plain)
2012-01-28 15:32 UTC, Franz Trischberger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markos Chandras (RETIRED) gentoo-dev 2012-01-28 12:21:16 UTC
I presume this is also true for 4.8.0


x86_64-pc-linux-gnu-g++ -Wl,-O1 -Wl,--hash-style=gnu,--enable-new-dtags -Wl,--as-needed -Wl,-O1 -o ../../../../bin/assistant .obj/release-shared/fontpanel.o .obj/release-shared/aboutdialog.o .obj/release-shared/bookmarkdialog.o .obj/release-shared/bookmarkfiltermodel.o .o
bj/release-shared/bookmarkitem.o .obj/release-shared/bookmarkmanager.o .obj/release-shared/bookmarkmanagerwidget.o .obj/release-shared/bookmarkmodel.o .obj/release-shared/centralwidget.o .obj/release-shared/cmdlineparser.o .obj/release-shared/contentwindow.o .obj/release-
shared/findwidget.o .obj/release-shared/filternamedialog.o .obj/release-shared/helpenginewrapper.o .obj/release-shared/helpviewer.o .obj/release-shared/indexwindow.o .obj/release-shared/installdialog.o .obj/release-shared/main.o .obj/release-shared/mainwindow.o .obj/relea
se-shared/preferencesdialog.o .obj/release-shared/qtdocinstaller.o .obj/release-shared/remotecontrol.o .obj/release-shared/searchwidget.o .obj/release-shared/topicchooser.o .obj/release-shared/xbelsupport.o .obj/release-shared/collectionconfiguration.o .obj/release-shared
/openpagesmodel.o .obj/release-shared/globalactions.o .obj/release-shared/openpageswidget.o .obj/release-shared/openpagesmanager.o .obj/release-shared/openpagesswitcher.o .obj/release-shared/helpviewer_qwv.o .obj/release-shared/moc_fontpanel.o .obj/release-shared/moc_abou
tdialog.o .obj/release-shared/moc_bookmarkdialog.o .obj/release-shared/moc_bookmarkfiltermodel.o .obj/release-shared/moc_bookmarkmanager.o .obj/release-shared/moc_bookmarkmanagerwidget.o .obj/release-shared/moc_bookmarkmodel.o .obj/release-shared/moc_centralwidget.o .obj/
release-shared/moc_contentwindow.o .obj/release-shared/moc_findwidget.o .obj/release-shared/moc_filternamedialog.o .obj/release-shared/moc_helpenginewrapper.o .obj/release-shared/moc_helpviewer.o .obj/release-shared/moc_helpviewer_p.o .obj/release-shared/moc_indexwindow.o
 .obj/release-shared/moc_installdialog.o .obj/release-shared/moc_mainwindow.o .obj/release-shared/moc_preferencesdialog.o .obj/release-shared/moc_qtdocinstaller.o .obj/release-shared/moc_remotecontrol.o .obj/release-shared/moc_searchwidget.o .obj/release-shared/moc_topicc
hooser.o .obj/release-shared/moc_openpagesmodel.o .obj/release-shared/moc_globalactions.o .obj/release-shared/moc_openpageswidget.o .obj/release-shared/moc_openpagesmanager.o .obj/release-shared/moc_openpagesswitcher.o .obj/release-shared/qrc_assistant.o .obj/release-shar
ed/qrc_assistant_images.o    -L/usr/lib64 -L/var/tmp/portage/x11-libs/qt-assistant-4.8.9999/work/qt-everywhere-opensource-src-4.8.9999/lib -L/var/tmp/portage/x11-libs/qt-assistant-4.8.9999/work/qt-everywhere-opensource-src-4.8.9999/plugins/sqldrivers -L/usr/lib64/qt4 -lQt
Help -L/usr/lib64 -L/var/tmp/portage/x11-libs/qt-assistant-4.8.9999/work/qt-everywhere-opensource-src-4.8.9999/lib -L/usr/X11R6/lib -lQtWebKit -lQtSql -lQtGui -lQtNetwork -lQtCore -lgthread-2.0 -lrt -lglib-2.0 -lpthread 
/usr/lib/gcc/x86_64-pc-linux-gnu/4.6.2/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lQtWebKit


This is because we pass "-webkit" on myconf.

Using -no-webkit seems works for me. Please verify if this is also valid in 4.8.0 before you push it to portage tree
Comment 1 Franz Trischberger 2012-01-28 14:03:10 UTC
Could this be an error in qt-git? qt-4.8.0 just emerged fine. qt-assistant depends hard on qt-webkit. If linking fails due to "missing" libQtWebkit, there must be an error somewhere else. Does compiling/running rekonq fail, too?
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 15:01:17 UTC
qt-assistant-4.8.9999 built fine with -no-webkit. I need someone to test if qt-assistant-4.8.0 can build with -no-webkit. I see the note about the upstream bug inside that ebuild, I just need to make sure this is still valid
Comment 3 Franz Trischberger 2012-01-28 15:32:16 UTC
Created attachment 300149 [details]
qt-assistant-4.8.0::qting-edge build log

Fails here, when building with -no-webkit
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 15:46:34 UTC
Can you please paste the useflags you are using for qt-assistant?
Comment 5 Franz Trischberger 2012-01-28 15:53:36 UTC
Use flags                 (-aqua) (c++0x) (-compat) (-debug) (-doc) (exceptions) (glib) (pch) (-qpa) (qt3support) (-trace) build_options: -trace
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 15:58:23 UTC
Thanks. I wonder if this is fixed upstream and we can get rid of the qt-webkit dependency.

Lowering severity as it seems to not affect 4.8.0 packages for now
Comment 7 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2012-01-28 16:11:23 UTC
For the record, it compiled fine here with Qt 4.8.0:
1) change -webkit to -no-webkit in src_configure
2) remove qt-webkit
3) emerge -av1 --nodeps qt-assistant

Franz, could you try it with portage? In your log there is -DQT_WEBKIT_LIB, which is not present in mine
Comment 8 Franz Trischberger 2012-01-28 16:35:07 UTC
> Franz, could you try it with portage? In your log there is -DQT_WEBKIT_LIB,
> which is not present in mine

It would be quite some work, as there are way too much (incompatbile) config-files.
I have qt-webkit installed, probably that's why qmake sets QT_WEBKIT_LIB. I will try uninstalling qt-webkit and reinstalling qt-assistant.
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 17:15:15 UTC
Interesting. This is an automagic dependency then. Either we workaround by dropping the marco from the cflags or patch the build system. I am not sure we will manage to fix that before 4.8.0 hits portage
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 18:23:33 UTC
This patch should allow building with -no-webkit even if webkit is installed

Index: qt-everywhere-opensource-src-4.8.9999/tools/assistant/tools/assistant/assistant.pro
===================================================================
--- qt-everywhere-opensource-src-4.8.9999.orig/tools/assistant/tools/assistant/assistant.pro
+++ qt-everywhere-opensource-src-4.8.9999/tools/assistant/tools/assistant/assistant.pro
@@ -2,7 +2,6 @@ include(../../../shared/fontpanel/fontpa
 TEMPLATE = app
 LANGUAGE = C++
 TARGET = assistant
-contains(QT_CONFIG, webkit):QT += webkit
 CONFIG += qt \
     warn_on \
     help
@@ -81,11 +80,8 @@ SOURCES += aboutdialog.cpp \
     openpageswidget.cpp \
     openpagesmanager.cpp \
     openpagesswitcher.cpp
-contains(QT_CONFIG, webkit) {
-    SOURCES += helpviewer_qwv.cpp
-} else {
-    SOURCES += helpviewer_qtb.cpp
-}
+
+SOURCES += helpviewer_qtb.cpp
 
 FORMS += bookmarkdialog.ui \
     bookmarkmanagerwidget.ui \
Comment 11 Franz Trischberger 2012-01-28 18:36:09 UTC
Of course this fixes compilation :) Also does it for qt-assistant-4.8.0.
Comment 12 Markos Chandras (RETIRED) gentoo-dev 2012-01-28 18:41:45 UTC
Thanks for testing.

Alex, please backport the qt-assistant-4.8.9999 changes and the disable-webkit.patch in 4.8.0 before you push it to portage.

Thanks
Comment 13 Markos Chandras (RETIRED) gentoo-dev 2012-01-29 19:05:27 UTC
This is now fixed