Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 40103 - russian patch broken with xmms 1.2.8 and above
Summary: russian patch broken with xmms 1.2.8 and above
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Sergey Kuleshov (RETIRED)
URL:
Whiteboard:
Keywords:
: 40270 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-02-01 11:18 UTC by Sergiy Borodych
Modified: 2004-02-10 05:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergiy Borodych 2004-02-01 11:18:32 UTC
xmms don't show filename in "View file info" if in "Encodings"->"Encodings Autoselection" enabled "Enable for Filesystem"

and also in "View file info" not encoding id3 tags
and right select of "ID3 Encoding" not help :(


Reproducible: Always
Steps to Reproduce:
1.run xmms
2.select "View file info" -> "Encodings" -> "Encodings Autoselection"
3.enable "Enable for Filesystem"




In xmms
"View file info" -> "Encodings"
Encodings->Output encoding = KOI8-U
Encoding autoselection->Language = Russian

root@work portage # locale
LANG=uk_UA.KOI8-U
LC_CTYPE="uk_UA.KOI8-U"
LC_NUMERIC=POSIX
LC_TIME="uk_UA.KOI8-U"
LC_COLLATE="uk_UA.KOI8-U"
LC_MONETARY="uk_UA.KOI8-U"
LC_MESSAGES=POSIX
LC_PAPER="uk_UA.KOI8-U"
LC_NAME="uk_UA.KOI8-U"
LC_ADDRESS="uk_UA.KOI8-U"
LC_TELEPHONE="uk_UA.KOI8-U"
LC_MEASUREMENT="uk_UA.KOI8-U"
LC_IDENTIFICATION="uk_UA.KOI8-U"
LC_ALL=
Comment 1 Sergiy Borodych 2004-02-01 11:23:19 UTC
Also
In playlist encodings is ok
and
root@work portage # emerge -pv xmms
[ebuild   R   ] media-sound/xmms-1.2.9-r1  -3dnow -cjk -directfb -esd +gnome -ipv6 +mikmod +mmx +nls +oggvorbis +opengl +xml  0 kB
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-01 12:55:14 UTC
Was this working in 1.2.8-r4?  Could you provide me with an mp3 with KOI8-U id3 tags so I can test this out?  It works fine for POSIX.

Comment 3 Sergiy Borodych 2004-02-02 05:11:32 UTC
No for 1.2.8-r4 id3 encodings not work too
AFAIR it start after 1.2.7-rxx for me
and I have mp3 with id3 tags in win (cp1251) and encoding it to KOI8-U
and right select of "ID3 Encoding" (cp1251) not help :(
any select of "ID3 Encoding" dosn't make any effects
it means symbols is same with any of "ID3 Encoding"
and not recognized

PS: sorry my English is not perfect ;)
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-02 10:44:18 UTC
Can you give me the mp3 with cp1251 tags to download?  Either post it here (if small) or a link.  I need one to test the bug on my own system.

Thank you.
Comment 5 Sergey Kuleshov (RETIRED) gentoo-dev 2004-02-02 12:01:43 UTC
I'll take this, cause it is much easier for me to fix :) xmms-1.2.9 ebuild is still using old patch, while there is a newer version specifically for 1.2.9. High chances that this is the source for the problem.
Comment 6 Sergiy Borodych 2004-02-02 15:02:58 UTC
Yes maybe

In portage tree now 
russian-charset-csa20.patch

but on http://rusxmms.sourceforge.net/
I see

30.01.2004 Version 1.2.9-csa27: updated to xmms 1.2.9

    * Starting from csa27 rusxmms is distributed in two versions:
          o againist pure xmms-1.2.9
          o againist xmms-1.2.9 with id3v2 patch applied
Comment 7 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-02 21:49:37 UTC
ARAIR, This patch also conflicts with dtd.  But it's nice they have the id3v2 friendly one to cut out 1/2 the headache ;)
Comment 8 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-03 21:01:25 UTC
*** Bug 40270 has been marked as a duplicate of this bug. ***
Comment 9 Sinom 2004-02-03 21:55:33 UTC
> No for 1.2.8-r4 id3 encodings not work too
> AFAIR it start after 1.2.7-rxx for me
> and I have mp3 with id3 tags in win (cp1251) and encoding it to KOI8-U
> and right select of "ID3 Encoding" (cp1251) not help :(
> any select of "ID3 Encoding" dosn't make any effects
> it means symbols is same with any of "ID3 Encoding"
> and not recognized

1) It is not bug. Don try experiment with patch, if you do not set correct font in fonts settings. XMMS > preferences > fonts > playlist > browse > filter > set/your/encoding In result it will be (example): -microsoft-verdana-medium-r-normal-*-*-110-*-*-p-*-koi8-r

2) THEN experiment with "Encodings" inset.

3) Oh, and check your ~/.gtkrc file. It must be consist correct fonts settings. For example it is my (warning: I use japenese font):

$ cat .gtkrc
# -- THEME AUTO-WRITTEN DO NOT EDIT
include "/usr/share/themes/Default/gtk/gtkrc"

style "user-font"
{
  fontset="-misc-fixed-medium-r-normal-*-*-130-*-*-c-*-jisx0201.1976-0"
}
widget_class "*" style "user-font"

include "/home/sinom/.gtkrc.mine"

# -- THEME AUTO-WRITTEN DO NOT EDIT
Comment 10 Sinom 2004-02-03 22:05:04 UTC
Bat all the same, XMMS patch for recoding id3 tags must be update.
In your ebuild script consist old patch - csa20
But there is new patch: http://sourceforge.net/projects/rusxmms/
It is 1.2.9-csa27.
Please create ebuild script with new patch.

PS Now it useful for other languages. Not only for russian. 

Comment 11 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-03 22:16:45 UTC
does the updated patch's support for other languages obsolete the mpg123j patch?
Comment 12 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-03 23:53:47 UTC
I just committed xmms-1.2.9-r2 which includes the csa27 patch
Comment 13 Sinom 2004-02-04 00:07:46 UTC
> does the updated patch's support for other languages obsolete the mpg123j patch?

no
May be in future.
I e-mail author about this.
Comment 14 Sergiy Borodych 2004-02-04 00:18:50 UTC
to  Sinom

I'm try do this operations a many times ;)
But no effects :(

Also in .gtkrc you set font for font in xmms menu ;)
not for show id3 tags
Comment 15 Sinom 2004-02-04 02:45:48 UTC
2 Sergey Borodich

> I'm try do this operations a many times ;) But no effects :(

Strange... It works perfectly for me. 
Now I use 1.2.7.

> Also in .gtkrc you set font for font in xmms menu ;)
> not for show id3 tags

Yes.
Comment 16 Sergiy Borodych 2004-02-04 06:53:46 UTC
I update my xmms to 1.2.9-r2

it problem is resolved

> xmms don't show filename in "View file info" if in "Encodings"->"Encodings Autoselection" enabled "Enable for Filesystem"

but id3 tags is not encoding :(
maybe I do something wrong ?

I select font 
-microsoft-verdana-medium-r-normal-*-*-110-*-*-p-*-koi8-r
and "Use fontset" is off
Comment 17 Sergey Kuleshov (RETIRED) gentoo-dev 2004-02-07 02:36:27 UTC
Ok, the new patch (csa27) works like a charm! A couple of note on how to set up XMMS properly.

1) Set the font XMMS uses according to your locale (KOI8-R/UTF-8/etc).
2) In case you have UTF-8 locale set also the flag "Load fonts as fontsets"
3) Go to Encodings tab.
4) Set Language to your lang.
5) Set flag "recode filenames"
6) Set all Encodings according to *your* locale
7) For Encoding autoselection set the desired algorithm to use + "Enable for FileSystem" flag.

I am closing this bug now, if you find any other problems with the patch - let me know.
Comment 18 Sergiy Borodych 2004-02-10 05:13:25 UTC
Thanks for tips
but I try it a many times


> 1) Set the font XMMS uses according to your locale (KOI8-R/UTF-8/etc).
I have 
root@work portage # locale
LANG=uk_UA.KOI8-U
LC_CTYPE="uk_UA.KOI8-U"
LC_NUMERIC=POSIX
LC_TIME="uk_UA.KOI8-U"
LC_COLLATE="uk_UA.KOI8-U"
LC_MONETARY="uk_UA.KOI8-U"
LC_MESSAGES=POSIX
LC_PAPER="uk_UA.KOI8-U"
LC_NAME="uk_UA.KOI8-U"
LC_ADDRESS="uk_UA.KOI8-U"
LC_TELEPHONE="uk_UA.KOI8-U"
LC_MEASUREMENT="uk_UA.KOI8-U"
LC_IDENTIFICATION="uk_UA.KOI8-U"
LC_ALL=

Set font 
playlist = -monotype-arial-medium-r-normal-*-*-110-*-*-p-*-koi8-u
main window = -monotype-times new roman-medium-r-normal-*-*-140-*-*-p-*-koi8-u

> 2) In case you have UTF-8 locale set also the flag "Load fonts as fontsets"
None
> 3) Go to Encodings tab.
Done ;)
> 4) Set Language to your lang.
Set Ukrainian
> 5) Set flag "recode filenames"
Done
> 6) Set all Encodings according to *your* locale
Set Output Encoding = KOI8-U
Here try play with ID3 Encoding - not effect :(
All another = Default
> 7) For Encoding autoselection set the desired algorithm to use + "Enable for FileSystem" flag.
Select Russian
+Set Enable for FileSystem"

Results:
In playlist name of songs is OK (I see it ;) )
In view file info - BAD

Sorry for unquiet :)