Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 400911 - media-sound/rhythmbox-2.95 lyrics plugin fails to save edited lyrics with gtk3 introspection (pygobject-3.0.3, gtk+-3.2.3)
Summary: media-sound/rhythmbox-2.95 lyrics plugin fails to save edited lyrics with gtk...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-01-26 13:30 UTC by Bernd Feige
Modified: 2012-04-01 17:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2012-01-26 13:30:11 UTC
Modifying the text and pressing "save" in the lyrics panel results in
TypeError: get_text() takes exactly 4 arguments (3 given)
Traceback (most recent call last):
  File "/usr/lib/rhythmbox/plugins/lyrics/lyrics.py", line 212, in edit_callback
    save_callback()
  File "/usr/lib/rhythmbox/plugins/lyrics/lyrics.py", line 202, in save_callback
    text = buf.get_text(startiter, enditer)
  File "/usr/lib/python2.7/site-packages/gi/types.py", line 43, in function
    return info.invoke(*args, **kwargs)
TypeError: get_text() takes exactly 4 arguments (3 given)

This is due to a third argument "gboolean include_hidden_chars" being required.

It can be fixed by the following simple patch to /usr/lib/rhythmbox/plugins/lyrics/lyrics.py:

=== modified file 'lyrics.py'
--- lyrics.py	2012-01-26 13:15:55 +0000
+++ lyrics.py	2012-01-26 13:16:08 +0000
@@ -199,7 +199,7 @@
 			buf = self.buffer
 			startiter = buf.get_start_iter()
 			enditer = buf.get_end_iter()
-			text = buf.get_text(startiter, enditer)
+			text = buf.get_text(startiter, enditer, False)
 			save_lyrics(self.cache_path, text)
 			self.get_lyrics()


Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2012-01-27 16:17:43 UTC
Can you report this to upstream also to let them know the problem and the fix?

-> bugzilla.gnome.org
Comment 2 Bernd Feige 2012-01-27 17:19:29 UTC
(In reply to comment #1)
> Can you report this to upstream also to let them know the problem and the fix?
> 
> -> bugzilla.gnome.org

Done: https://bugzilla.gnome.org/show_bug.cgi?id=668864
Comment 3 Pacho Ramos gentoo-dev 2012-04-01 17:51:19 UTC
*rhythmbox-2.96 (29 Mar 2012)

  29 Mar 2012; Nirbheek Chauhan <nirbheek@gentoo.org> +rhythmbox-2.96.ebuild:
  Bump to 2.96, remove old later