Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 40048 - rpc.yppasswdd init script doesn't have any options
Summary: rpc.yppasswdd init script doesn't have any options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Nick Hadaway
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-01 01:10 UTC by Paul Komarek
Modified: 2004-06-09 07:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Komarek 2004-02-01 01:10:29 UTC
We use a non-default dir for our yp/nis sources, so yppasswdd needs a -D arg.  Furthermore, yppasswdd needs args to enable chsh and chfn behavior.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




I suggest the following patch to /etc/init.d/rpc.yppasswdd.  It is intended to
be used with a config file /etc/conf.d/rpc.yppasswdd.

--- rpc.yppasswdd       2004-02-01 08:57:29.000000000 +0000
+++ rpc.yppasswdd.new   2004-02-01 08:57:12.000000000 +0000
@@ -8,7 +8,10 @@
  
 start() {
        ebegin "Starting rpc.yppasswdd"
-       start-stop-daemon --start --quiet --exec /usr/sbin/rpc.yppasswdd
+       YOPTS=""
+       if [ -n "${YPPASSWDD_OPTS}" ]; then YOPTS="-- $YPPASSWDD_OPTS"; fi
+       start-stop-daemon --start --quiet --exec /usr/sbin/rpc.yppasswdd \
+         ${YOPTS}
        eend $?
 }


For my /etc/conf.d/rpc.yppasswdd, a sensible default file might be:

# bunch of copyright stuff goes here

# yppasswdd options.  -e chsh allows changing shell through ypchsh,
# -e chfn allows changing GECOS ("finger") information through ypchfn,
# and -D <dir> allows specification of directory with yp/NIS sources
# if other than /etc.
#YPPASSWDD_OPTS="-e chsh -e chfn -D <dir>"

-Paul Komarek
Comment 1 Jacob Joseph 2004-03-22 20:19:08 UTC
I'd just like to second this motion.  If nothing else, -D should default to /var/yp/source so that it works with the rest of the gentoo setup.  Out of the box, rpc.yppasswdd is useless.  I'd love to see action on this sooner than later.

-Jacob
Comment 2 Donny Davies (RETIRED) gentoo-dev 2004-03-23 06:46:32 UTC
Bumping back to wranglers due to no time; sorry.
Comment 3 Paul Komarek 2004-05-10 21:53:08 UTC
This 4-line patch to the rpc.yppasswdd script is very simple.  The patch can be applied without adding a /etc/conf.d file.  Those who can read shell scripts can discover it and make use of it.  The idea of the patch is to check whether the YPPASSWDD_OPTS environment variable is set (perhaps through automatic conf.d/yppasswdd sourcing), and if it is then append those options to the line that starts yppasswdd.

This bug has been open for 3 months.  I would really like to see this issue resolved.  What can I do to help resolve it?  Is the patch intrusive, or otherwise offensive in some way?

-Paul Komarek
Comment 4 Jacob Joseph 2004-06-04 06:52:08 UTC
I consider this bug extremely important in that yppasswd is nearly unusable in any sort of production environment.  Furthermore, the above patch is provided.  It's not as if anyone needs to spend any significant amount of time testing.  It's not as if things could be more broken anyway.  I'm not sure here what the focus of Gentoo is, but if we're unable to integrate a simple, provided patch to provide much needed functionality 4 months after being reported, what's the point of bugzilla?

-Jacob
Comment 5 Nick Hadaway 2004-06-07 22:30:57 UTC
ypserv-2.13-r1 is now in portage with your suggested changes.  If there is anything else you'd like me to change, please let me know.  Sorry this has taken so long to get in.  Re-open this bug if you find any issues this doesn't address properly.
Comment 6 Paul Komarek 2004-06-09 07:36:19 UTC
Thanks!