Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 399631 - dev-vcs/stgit-0.16 version bump
Summary: dev-vcs/stgit-0.16 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: René 'Necoro' Neumann
URL: http://www.procode.org/stgit/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-21 17:21 UTC by René 'Necoro' Neumann
Modified: 2012-01-23 16:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild diff (stgit-0.16.ebuild.diff,759 bytes, patch)
2012-01-21 17:21 UTC, René 'Necoro' Neumann
Details | Diff
stgit-0.16-missing-patches.tar.gz (stgit-0.16-missing-patches.tar.gz,1.63 KB, application/octet-stream)
2012-01-21 17:22 UTC, René 'Necoro' Neumann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2012-01-21 17:21:05 UTC
Created attachment 299459 [details, diff]
Ebuild diff

The developers of dev-vcs/stgit have released a new version. I adopted the ebuild for this new version (see attached diff).

The missing-patches.tar.gz need to be put onto the Gentoo Mirrors (just like stgit-0.15-missing-patches.tar.gz) -- they are indeed just a copy of them modulo renaming the top-most directory.
Comment 1 René 'Necoro' Neumann 2012-01-21 17:22:19 UTC
Created attachment 299461 [details]
stgit-0.16-missing-patches.tar.gz

The missing patches...
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-01-23 13:58:31 UTC
Ok, committed. There is no need to place a copy of the patches on the mirrors, instead use the old file directly.
Comment 3 René 'Necoro' Neumann 2012-01-23 14:11:43 UTC
Nope ... using mirror://gentoo/${PN}-0.15-missing-patches.tar.gz directly does NOT work, as the tar.gz includes the top-directory "stgit-0.15" and thus does not unpack the patches into the stgit-sources in the directory "stgit-0.16".

I have no good idea though on how to solve this in a more general way w/o copying stuff around.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-01-23 15:53:27 UTC
Ok, I don't understand how those missing patches even work. Can you tell me during what phase they actually get applied? Upon studying the build.log I don't see any mention of appliying patches or such.
Comment 5 René 'Necoro' Neumann 2012-01-23 16:02:56 UTC
They are used solely in the test-phase: One test (t1800) tries to apply various patches and looks whether stgit behaves... unfortunately the tests to apply are not included in the tarball and thus this test would always fail.

Hence another option would be to remove this single test.
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-01-23 16:20:21 UTC
Oh, I see. Thanks for explaining. I could go either way on removing the test. However, at this point in time, it is easier to just upload the tarball that you provided. :) I'll commit a fix in an hour or so to allow the distfile to propagate to the mirrors.