Bug 399617 – =dev-libs/stlsoft-1.9.111 ( New package )

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dmitriy Vilkov 2012-01-21 15:41:02 UTC]

Hello, would you please add this ebuild to the portage tree (dev-libs/stlsoft).
If it is possible I would like to become a maintainer of this library.

[Comment 1 Agostino Sarubbo 2012-01-21 19:45:05 UTC]

yes, is possible, did you have make the ebuild? attach it

[Comment 2 Dmitriy Vilkov 2012-01-21 20:23:01 UTC]

Created attachment 299465 [details]
Ebuild file.

Sorry, I just forgot to attach the file.
Yes I've made the ebuild file and tested it on my local overlay.

[Comment 3 Agostino Sarubbo 2012-01-22 17:55:51 UTC]

The ebuild looks ok.

@Proxy-maint, any of you can take care of it?

[Comment 4 Markos Chandras (RETIRED) 2012-01-22 18:47:43 UTC]

Thanks for you submission but the ebuild is not good

- Why use SLOT="1.9" instead of 0? Do you plan on submitting ebuilds for other slots too?
- Do not use stable keywords when you submit ebuilds
- Have you tested your ebuild on all of these arches? If not, use the keywords you have actual tested your package on.
- You don't use any functions from the eutils eclass so you don't need to inherit it

[Comment 5 Agostino Sarubbo 2012-01-22 19:08:59 UTC]

wut :/

I considered obviously the keywords stuff, but I didn't see the slot issue.

works on amd64 btw

[Comment 6 Agostino Sarubbo 2012-01-22 19:10:23 UTC]

and please set RDEPEND="" or repoman will annoyng in the future :)

[Comment 7 Dmitriy Vilkov 2012-01-25 13:08:03 UTC]

Created attachment 299843 [details]
Ebuild v2

[Comment 8 Dmitriy Vilkov 2012-01-25 13:08:14 UTC]

Thank you for your comments.

> - Why use SLOT="1.9" instead of 0? Do you plan on submitting ebuilds for other
> slots too?
Yes, there is 1.10 beta branch. I will post ebuild for it after this one.

> - Do not use stable keywords when you submit ebuilds
> - Have you tested your ebuild on all of these arches? If not, use the keywords
> you have actual tested your package on.
Ok, I updated the keywords.

> - You don't use any functions from the eutils eclass so you don't need to
> inherit it
Fixed.

[Comment 9 Markos Chandras (RETIRED) 2012-01-25 19:26:22 UTC]

Thanks. We will try to push it as soon as possible

[Comment 10 Markos Chandras (RETIRED) 2012-01-28 21:46:27 UTC]

(In reply to comment #8)
> Thank you for your comments.
> 
> > - Do not use stable keywords when you submit ebuilds
> > - Have you tested your ebuild on all of these arches? If not, use the keywords
> > you have actual tested your package on.
> Ok, I updated the keywords.

You still have stable keywords (amd64, x86) in there. I don't believe you have actually tested this package in hppa, ppc, ppc64 and alpha arches so I dropped them. 

Now in gx86