Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398855 - dev-libs/xalan-c: drop has_m64 usage
Summary: dev-libs/xalan-c: drop has_m64 usage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: C++ Team [disbanded]
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks:
 
Reported: 2012-01-14 08:21 UTC by SpanKY
Modified: 2017-02-12 09:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for xalan-c-1.11.0_pre1153059.ebuild (xalan-c-1.11.0_pre1153059.ebuild.diff,965 bytes, patch)
2017-02-11 09:47 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2012-01-14 08:21:58 UTC
the has_m64 flag doesn't really work.  not all 64bit targets accept -m64, and some 32bit targets which support multilib can accept -m64.

in reading the xalan-c code, it doesn't seem like the bitstobuild= configure flag is even useful.  when it has a value of "32", it doesn't add any flags, and when it is "64", it adds hardcoded flags for some targets.  all of that should be taken care of already by the user's toolchain.

i would just set bitstobuild=32 since that code path seems to not do anything
Comment 1 Ulrich Müller gentoo-dev 2017-02-11 09:43:21 UTC
Any progress here? This appears to be the last ebuild blocking removal of the has_m64 function in flag-o-matic.eclass (and therefore, removal of the eutils inherit in that eclass).

(In reply to SpanKY from comment #0)
> in reading the xalan-c code, it doesn't seem like the bitstobuild= configure
> flag is even useful.  when it has a value of "32", it doesn't add any flags,
> and when it is "64", it adds hardcoded flags for some targets.

Especially, it doesn't add any flags at all for platform=linux.

> i would just set bitstobuild=32 since that code path seems to not do anything

It's the default, so can be removed altogether.
Comment 2 Ulrich Müller gentoo-dev 2017-02-11 09:47:21 UTC
Created attachment 463188 [details, diff]
Patch for xalan-c-1.11.0_pre1153059.ebuild

Proposed patch.

The build.log on amd64 with this patch differs only by one line from the one without (which verifies that the bitstobuild option is a no-op):

- * has_m64: don't use this anymore

So should be safe to do this in place without a revbump.
Comment 3 Ulrich Müller gentoo-dev 2017-02-12 09:24:56 UTC
commit e919ffe0bd16d9e6dcfe7ed82c3b18e2c67a6051
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Sun Feb 12 10:20:28 2017 +0100

    dev-libs/xalan-c: Drop has_m64 usage.
    
    Remove the bitstobuild option which has no effect on Linux.
    Non-maintainer commit, acked by soap.
    
    Bug: 398855
    
    Package-Manager: Portage-2.3.3, Repoman-2.3.1