Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398803 - net-wireless/atmel-firmware: incorrectly named firmwares
Summary: net-wireless/atmel-firmware: incorrectly named firmwares
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 20:36 UTC by Maxim Kammerer
Modified: 2013-01-01 14:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-01-13 20:36:09 UTC
It appears that the atmel-firmware package has a couple of firmwares that are incorrectly named (not according to what kernel sources use).

for fw in `qlist atmel|sed -n 's:/lib/firmware/::p'`; do
    if ! grep -qr ${fw} /usr/src/linux/drivers/net/wireless; then
        echo ${fw}
    fi
done

Produces (3.0.4):

atmel_at76c504c-wpa.bin
atmel_at76c503-rfmd-0.90.2-140.bin

The first one should be probably drop the "c" - /usr/src/linux/drivers/net/wireless/atmel.c has MODULE_FIRMWARE("atmel_at76c504-wpa.bin")). It's not due to the kernel version either - try searching the net for atmel_at76c504c-wpa.bin with/without MODULE_FIRMWARE.

The second one should be probably dropped altogether - the naming convention is weird, and /usr/src/linux/drivers/net/wireless/at76c50x-usb.c has references to two atmel_at76c503-rfmd* files in the package.

I am classifying the bug as minor, as there apparently is a pre-wpa (whatever that means) version of atmel_at76c504c-wpa.bin in the package (atmel_at76c504.bin).

Caveat emptor: all of the above is only a guess; should be probably checked with upstream.
Comment 1 Pacho Ramos gentoo-dev 2012-12-18 21:17:35 UTC
Debian package is providing exactly that files and they look to work ok... what exact problem are you suffering?
Comment 2 Maxim Kammerer 2012-12-18 22:01:51 UTC
The files work (probably) due to details I posted above. I have sent a question about this to package's author, Simon Kelley <simon@thekelleys.org.uk>.
Comment 3 Maxim Kammerer 2012-12-18 23:12:28 UTC
Here is the response from Simon Kelley:

-----
Wow, this is ancient history indeed. The Atmel wireless chips never made it beyond 802.11b, so I doubt many people are still using them. I still have some atmel hardware, but nothing with a PCMCIA slot to plug them into.

I think it may be true that there's a typo in either the filename or the kernel table for atmel_at76c504c-wpa.bin. I guess nobody even noticed because it will fall back to using atmel_at76c504.bin which is functionally equivalent.

As far as atmel_at76c503-rfmd-0.90.2-140.bin goes, that's for the USB variant, which has a different driver that I had no part in. I packaged all the possible firmwares so that everything that driver might need would be available. If you want to lose that file, best to ask the maintainers of at76c50x-usb.c, if they're still alive!
-----

It seems that wrt. atmel_at76c503-rfmd-0.90.2-140.bin, it can indeed be used, after going over drivers/net/wireless/at76c50x-usb.c (e.g., search for "snprintf").

So it's down to one file: atmel_at76c504c-wpa.bin. Maybe it should be renamed to atmel_at76c504-wpa.bin. Someone with relevant hardware would need to test, I guess.
Comment 4 Pacho Ramos gentoo-dev 2013-01-01 14:42:34 UTC
+*atmel-firmware-1.3-r1 (01 Jan 2013)
+
+  01 Jan 2013; Pacho Ramos <pacho@gentoo.org> +atmel-firmware-1.3-r1.ebuild:
+  atmel_at76c504c-wpa.bin should be renamed to atmel_at76c504-wpa.bin, bug
+  #398803 by Maxim Kammerer
+