Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398471 - [patch] sys-kernel/genkernel configuration file cleanup
Summary: [patch] sys-kernel/genkernel configuration file cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2012-01-11 04:28 UTC by Tomasz Wasiak
Modified: 2012-03-22 03:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Small cleanup of genkernel.conf. (genkernel-3.4.22.1-cfgfile_cleanup.patch,4.08 KB, patch)
2012-01-11 04:29 UTC, Tomasz Wasiak 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Wasiak 2012-01-11 04:28:33 UTC 
Just a small cleanup of configuration file.

Reproducible: Always
Comment 1 Tomasz Wasiak 2012-01-11 04:29:26 UTC 
Created attachment 298591 [details, diff]
Small cleanup of genkernel.conf.

Applies to genkernel 3.4.22.1 and 3.4.22-2-g8a91222.
Comment 2 Sebastian Pipping gentoo-dev 2012-01-12 03:14:17 UTC 
Hello Tomasz,

I think keeping commented out options as "^#[A-Z]" helps to visually distinguish comments and commented out variables.  It seems the current genkernel.conf is inconsistent about this.  How would you like fixing these

  grep -E '^# [A-Z_]+=' genkernel.conf

to not use the space, instead?
Comment 3 Tomasz Wasiak 2012-01-12 04:16:24 UTC 
If you want to have easily distinguishable comments and commented variables it could be good idea just remove spaces from those '^# [A-Z_]+=' lines to make whole file consistent.