39834 – localmount from baselayout doesnt evaluate the return code from swapon

Bug 39834 - localmount from baselayout doesnt evaluate the return code from swapon

Summary: localmount from baselayout doesnt evaluate the return code from swapon

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] baselayout (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-01-29 19:15 UTC by Nils Ohlmeier
Modified:	2004-10-03 01:27 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nils Ohlmeier 2004-01-29 19:15:10 UTC

/etc/init.d/localmount from sys-apps/baselayout-1.8.6.10-r1 up to 1.8.5.12-r5 dows not evaluated the return code from the swapon call at the end of the script. At the end is a simple 'eend 0' which leads to a beautifull [ok] even if swapon failed for some reason (the swapon output is surpressed to /dev/null).

Reproducible: Always
Steps to Reproduce:
1. make your swap partition non mountable
2. call /et/init.d/localmount
3.
Actual Results:  
It prints in every case [ok]. (And thus i missed that my box was running 
without swap.) 

Expected Results:  
It should print [failed] in case an error occured during swapon. 

I suggest to replace the 'eend 0' in line 55 of localmount with 'eend $?'.

Comment 1 SpanKY gentoo-dev

2004-10-03 01:27:06 UTC

fixed in cvs ... looks like it's just code that's existed ever since the first baselayout ...