Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 397455 - =net-libs/libproxy-0.4.7 does not support GNOME2
Summary: =net-libs/libproxy-0.4.7 does not support GNOME2
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 02:16 UTC by Mart Raudsepp
Modified: 2015-07-07 10:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2012-01-03 02:16:11 UTC
libproxy-0.4.7.ebuild does not support GNOME2, despite thinking it does per the ebuild text:

 			$(cmake-utils_use_with gnome GNOME)
+			$(cmake-utils_use_with gnome GNOME3)

that is, both GNOME2 and GNOME3 are thought to be enabled with USE=gnome,
but this is not how it is done per the cmake build files in 0.4.7 now in libproxy/cmake/modules/config_gnome.cmk:

  option(WITH_GNOME3 "Target a GNOME 3 system (gsettings)" ON)
  if(WITH_GNOME3)
    px_check_modules(GNOME3 gio-2.0>=2.26 gobject-2.0)
  else(WITH_GNOME3)
    px_check_modules(GNOME2 gconf-2.0 gobject-2.0)
  endif(WITH_GNOME3)
  
  # GNOME (gconf) helper
  if(GNOME2_FOUND OR GNOME3_FOUND)
    if(WITH_GNOME3)
      add_executable(pxgsettings modules/pxgsettings.cpp)
      target_link_libraries(pxgsettings ${GNOME3_LIBRARIES})
      install(TARGETS pxgsettings RUNTIME DESTINATION ${LIBEXEC_INSTALL_DIR})
    else(WITH_GNOME3)
      add_executable(pxgconf modules/pxgconf.cpp)
      target_link_libraries(pxgconf ${GNOME2_LIBRARIES})
      install(TARGETS pxgconf RUNTIME DESTINATION ${LIBEXEC_INSTALL_DIR})
    endif(WITH_GNOME3)
  endif()

That is, one or the other can be enabled, not both.
This is actually also the case, as witnessed by portage output on upgrading:


>>> Installing (1 of 1) net-libs/libproxy-0.4.7

>>> /usr/lib64/libproxy/0.4.7/modules/config_gnome3.so

<<<          obj /usr/lib64/libproxy/0.4.6/modules/config_gnome.so


However, the deps are adjusted to be only for GNOME3, that is, the gconf dependeny is removed in the bump:


-RDEPEND="gnome? ( gnome-base/gconf:2 )
+RDEPEND="gnome? ( >=dev-libs/glib-2.26:2 )


In short, we now lost support for reading stable GNOME-2.32 proxy settings from GConf, as libproxy-0.4.7 was stabilized per bug 394363, whereas GNOME3 is not stabilized.
This all assumes stable GNOME (2.32) uses GConf for storing proxy settings, not also GSettings (in which case the connection between GSettings and GNOME3 in libproxy upstream would be wrong instead).

Did anyone test actual proxy settings honoring with stable 2.32 and libproxy-0.4.7 ebuild?
Comment 1 Pacho Ramos gentoo-dev 2012-01-17 13:11:55 UTC
I have just confirmed (via my father, that uses a proxy) that proxy support is not broken with 0.4.7. It was having problems with browsing with epiphany and weather applet, I though they were caused by this updated and, then, asked him to downgrade to 0.4.6... but it didn't solve anything. On the other hand, setting proxy via dconf-editor fixed all the problems -> we need to solve bug 327595, but I don't have time to backport:
http://git.gnome.org/browse/gnome-control-center/commit/?id=2a5eca505ddf0b7023d18f0b96efb811c1532c3d

I also need someone with more knowledge to check that commit and confirm it would be safe to backport (leio, aren't you still using gnome2? Looks like most of the team is running gnome3 :S)
Comment 2 Pacho Ramos gentoo-dev 2012-01-17 14:47:08 UTC
There is a bit more info in:
http://code.google.com/p/libproxy/issues/detail?id=131

But I don't know why they made both supports exclusive :/

Looks like epiphany and weather applet are reading dconf settings, while others like mail-notification are still relying on gconf :S
Comment 3 Pacho Ramos gentoo-dev 2015-07-07 10:30:10 UTC
This should be obsolete now that we only have gnome3