Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395649 - autotools-utils.eclass should not always run elibtolize in src_prepare
Summary: autotools-utils.eclass should not always run elibtolize in src_prepare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 392073
  Show dependency tree
 
Reported: 2011-12-22 07:34 UTC by Justin Lecher (RETIRED)
Modified: 2011-12-22 18:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Add a note on AT_NOELIBTOOLIZE=yes in src_prepare(). (Add-a-note-on-ATNOELIBTOOLIZEyes-in-srcprepare.patch,991 bytes, patch)
2011-12-22 17:21 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2011-12-22 07:34:30 UTC
In case I want to run

	autotools-utils_src_prepare
	eautoreconf

the current implementation will end in

 * Running elibtoolize in: memphis-0.2.3/
 *   We've already been run in this tree; you should
 *   avoid this if possible (perhaps by filing a bug)


This is related to bug 392073. Until that one is fixed, could you please implement a workaround for the situation if a eautoreconf call is needed. Or add somthing to the man page which points to the AT_NOELIBTOOLIZE="yes" option.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-22 17:21:02 UTC
Created attachment 296673 [details, diff]
Add a note on AT_NOELIBTOOLIZE=yes in src_prepare().

Fixes:
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-22 17:21:43 UTC
(In reply to comment #1)
> Created attachment 296673 [details, diff] [details, diff]
> Add a note on AT_NOELIBTOOLIZE=yes in src_prepare().

Does this suit you? I wasn't sure where to add such a note, so I did to autotools-utils_src_prepare().
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2011-12-22 17:47:08 UTC
yes, looks good.
Why do we need to run elibtoolize always?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-22 18:01:33 UTC
(In reply to comment #3)
> yes, looks good.
> Why do we need to run elibtoolize always?

Applies a few patches to ltmain.sh. Best ask vapier.

Fix committed.