Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395489 - elibtoolize from libtool.eclass: improve message "We've already been run in this tree"
Summary: elibtoolize from libtool.eclass: improve message "We've already been run in t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: Normal trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-21 08:56 UTC by Martin von Gagern
Modified: 2011-12-21 21:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2011-12-21 08:56:50 UTC
Currently the elibtoolize eclass will generate an ewarn for duplicate execution:

    einfo "Running elibtoolize in: ${d#${WORKDIR}/}/"
    if [[ -f ${d}/.elibtoolized ]] ; then
        ewarn "  We've already been run in this tree; you should"
        ewarn "  avoid this if possible (perhaps by filing a bug)"
    fi

If using elog modules, those ewarn lines might end up out of context. For example I just got the following message by e-mail:

WARN: prepare
  We've already been run in this tree; you should
  avoid this if possible (perhaps by filing a bug)

This is less useful than it could be, because 1) it doesn't say who "we" is, and 2) it doesn't say what "this tree" is. So I suggest you change those lines to

        ewarn "  elibtoolize has already been run in ${d#${WORKDIR}/}/;"
        ewarn "  you should avoid this if possible (perhaps by filing a bug)"

This includes all the relevant information from the previous einfo in the ewarn as well, thus making the ewarn not depend on the einfo and useful out of context.

The lack of information has been mentioned in other bugs as well:
* bug #391749 comment #3
* bug #394709 comment #0