Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395329 - app-portage/portage-utils-0.8: qlist no longer list slots if requested
Summary: app-portage/portage-utils-0.8: qlist no longer list slots if requested
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage Utils Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-19 23:56 UTC by emerald
Modified: 2011-12-20 22:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-utils-0.8-fix-slots.patch (portage-utils-0.8-fix-slots.patch,4.68 KB, patch)
2011-12-20 21:27 UTC, Patrick McLean
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description emerald 2011-12-19 23:56:42 UTC
qlist should display slot numbers, if requested by -S but doesn't anymore with portage-utils 0.8. Version 0.6 tested just now works as expected.

emerald ~ # qlist -ICSL x11-drivers/
x11-drivers/nvidia-drivers:
x11-drivers/xf86-input-aiptek:
x11-drivers/xf86-input-evdev:
x11-drivers/xf86-input-joystick:
x11-drivers/xf86-input-keyboard:
x11-drivers/xf86-input-mouse:
x11-drivers/xf86-input-void:
x11-drivers/xf86-video-fbdev:
x11-drivers/xf86-video-nv:
x11-drivers/xf86-video-v4l:
x11-drivers/xf86-video-vesa:
Comment 1 Patrick McLean gentoo-dev 2011-12-20 21:27:13 UTC
Created attachment 296483 [details, diff]
portage-utils-0.8-fix-slots.patch

Patch that fixes the problem.

It's actually 2 bugs, the method qlist was using to obtain the slot had stopped working, and the stack was being clobbered with -U which was replacing the slot information with the first USE flag.

There might be a better way of doing this, my C is pretty rusty ATM.
Comment 2 SpanKY gentoo-dev 2011-12-20 22:48:41 UTC
ah simple is simpler than that.  your patch does fix the non-reentrant nature of the grab_vdb_item func, but i'm going to keep putting that off for now ;).

http://sources.gentoo.org/gentoo-projects/portage-utils/qlist.c?r1=1.66&r2=1.67