Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395101 - app-text/tree-1.6.0 has wrong bash completion filename
Summary: app-text/tree-1.6.0 has wrong bash completion filename
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Normal minor (vote)
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-17 20:40 UTC by Laurent Bachelier
Modified: 2011-12-18 05:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Bachelier 2011-12-17 20:40:57 UTC
The ebuild creates a /usr/share/bash-completion/tree.bashcomp whereas every other file in that directory does not have the bashcomp extension.

This is most likely related to the switch from the bash-completion eclass to bash-completion-r1.

Solution:
replace dobashcomp "${FILESDIR}"/${PN}.bashcomp
by newbashcomp "${FILESDIR}"/${PN}.bashcomp tree

Reproducible: Always
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2011-12-17 22:42:00 UTC
Why does it matter what the file is called?
Comment 2 Laurent Bachelier 2011-12-18 01:09:47 UTC
(In reply to comment #1)
> Why does it matter what the file is called?

In eselect bashcomp list, you will see, for instance:

  [183] tcpdump
  [184] tig *
  [185] tree.bashcomp
  [186] udisks *
  [187] unace

It just feels weird an incorrect.



Moreover, with the previous eclass, it was simply named 'tree'; I don't think the change was intentional (the behavior was to use ${PN}, it's not enforced anymore in the newer eclass.)

That reminds me, it's probably better to use:
newbashcomp "${FILESDIR}"/${PN}.bashcomp ${PN}
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2011-12-18 05:41:56 UTC
consistent eselect output is a good argument.  fixed in portage.