Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 394141 - dev-libs/mpfr: weaken a bit static-libs use deps
Summary: dev-libs/mpfr: weaken a bit static-libs use deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 12:26 UTC by Alexis Ballier
Modified: 2011-12-09 20:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2011-12-09 12:26:34 UTC
currently mpfr ebuilds have the following dep:
RDEPEND=">=dev-libs/gmp-4.1.4-r2[static-libs=]"

while it is very good to propagate static-libs, imho, we do not need to force gmp[-static-libs] with mpfr[-static-libs]

proposed patch:

Index: mpfr-3.0.1_p4-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-libs/mpfr/mpfr-3.0.1_p4-r1.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 mpfr-3.0.1_p4-r1.ebuild
--- mpfr-3.0.1_p4-r1.ebuild	25 Aug 2011 19:44:27 -0000	1.1
+++ mpfr-3.0.1_p4-r1.ebuild	9 Dec 2011 12:26:01 -0000
@@ -19,7 +19,7 @@
 KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~sparc-fbsd ~x86-fbsd"
 IUSE="static-libs"
 
-RDEPEND=">=dev-libs/gmp-4.1.4-r2[static-libs=]"
+RDEPEND=">=dev-libs/gmp-4.1.4-r2[static-libs?]"
 DEPEND="${RDEPEND}"
 
 S=${WORKDIR}/${MY_P}
Index: mpfr-3.1.0.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-libs/mpfr/mpfr-3.1.0.ebuild,v
retrieving revision 1.2
diff -u -B -r1.2 mpfr-3.1.0.ebuild
--- mpfr-3.1.0.ebuild	29 Nov 2011 16:52:55 -0000	1.2
+++ mpfr-3.1.0.ebuild	9 Dec 2011 12:26:01 -0000
@@ -19,7 +19,7 @@
 KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 -sparc-fbsd -x86-fbsd"
 IUSE="static-libs"
 
-RDEPEND=">=dev-libs/gmp-4.1.4-r2[static-libs=]"
+RDEPEND=">=dev-libs/gmp-4.1.4-r2[static-libs?]"
 DEPEND="${RDEPEND}"
 
 S=${WORKDIR}/${MY_P}
Comment 1 SpanKY gentoo-dev 2011-12-09 17:01:43 UTC
while you can technically statically link against just mpfr while dynamically linking against everything else, that is the extremely unlikely case.

mpfr needs gmp.  if you do a static link, it will need the gmp static libraries.  packages doing static linking against mpfr shouldn't have to also depend on all of mpfr's deps.  thus the static-libs needs to ripple.
Comment 2 Alexis Ballier gentoo-dev 2011-12-09 17:51:30 UTC
nonono, you didnt get the point: i like the static-libs use propagation, however, i want to statically link against _gmp_ thus enabled static-libs on gmp but i have no use of mpfr static libs, with the = use dep, this forces me to also enable static-libs on mpfr, with the ? use dep, if i want mpfr static-libs i'll need gmp static-libs but not the other way around.
Comment 3 SpanKY gentoo-dev 2011-12-09 20:29:52 UTC
feel free to commit then w/out revbump
Comment 4 Alexis Ballier gentoo-dev 2011-12-09 20:49:15 UTC
done