Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 393675 - lxde-base/lxdm-0.4.1-r2 - provide PAM support
Summary: lxde-base/lxdm-0.4.1-r2 - provide PAM support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: LXDE team (DEFUNCT)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 22:08 UTC by Mitch Harder
Modified: 2012-02-04 10:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch configure.ac to test for pam (lxdm-0.4.1-Fix-configure.ac-test-for-pam-libs.patch,1.38 KB, patch)
2011-12-08 22:10 UTC, Mitch Harder
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mitch Harder 2011-12-08 22:08:30 UTC
PAM support was removed from lxde-base/lxdm-0.4.1 in version r2 because of an issue with testing for pam libraries in the configure step.

See Gentoo bug 384615
https://bugs.gentoo.org/show_bug.cgi?id=384615

I have patched the configure.ac file based on the example provided in xdm, and I am supplying this patch as in an attachment as:
lxdm-0.4.1-Fix-configure.ac-test-for-pam-libs.patch

(Note:  It doesn't look like attachments can be supplied in the initial report, I'll have to attach in a follow-up).

Also, I thought it would make sense to add a 'pam' USE flag to the lxdm ebuild.  Again, I followed the example used in xdm since it would make sense to keep these two ebuilds similar if practical.

Here's a diff of my changes to the ebuild that I used:

--- /usr/portage/lxde-base/lxdm/lxdm-0.4.1-r2.ebuild	2011-09-27 07:38:52.000000000 -0500
+++ /usr/local/portage/lxde-base/lxdm/lxdm-0.4.1-r2.ebuild	2011-12-08 15:43:52.000000000 -0600
@@ -14,14 +14,14 @@
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
 
-IUSE="debug gtk3 nls"
+IUSE="debug gtk3 nls pam"
 
-RDEPEND="sys-libs/pam
-	sys-auth/consolekit
+RDEPEND="sys-auth/consolekit
 	x11-libs/libxcb
 	gtk3? ( x11-libs/gtk+:3 )
 	!gtk3? ( x11-libs/gtk+:2 )
-	nls? ( sys-devel/gettext )"
+	nls? ( sys-devel/gettext )
+	pam? ( virtual/pam )"
 DEPEND="${RDEPEND}
 	>=dev-util/intltool-0.40
 	dev-util/pkgconfig"
@@ -45,6 +45,8 @@
 	# Fix null pointer dereference, backported from git
 	epatch "${FILESDIR}/${P}-git-fix-null-pointer-deref.patch"
 
+	epatch "${FILESDIR}/${P}-Fix-configure.ac-test-for-pam-libs.patch"
+
 	# this replaces the bootstrap/autogen script in most packages
 	eautoreconf


Reproducible: Always
Comment 1 Mitch Harder 2011-12-08 22:10:34 UTC
Created attachment 295223 [details, diff]
Patch configure.ac to test for pam

Here's the patch I referenced when I opened this bug.
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2012-02-04 10:40:28 UTC
Thanks but I would like this patch to be reported upstream too. Could you do it?

Fixed in 0.4.1-r3