After installing mldonkey-2.5.4, I was pleased to notice that service facilities (init.d, conf.d, own homedir) have been added. Unfortunately, using /home/mldonkey as the homedir doesn't seem to be such a good idea; it would be better (as done by many other distros) to put it into /srv/mldonkey. Besides that, I think that mldonkey should have an own user ("mldonkey") instead of the fairly generic "p2p": What if (at a later time) other services like this are to be added. A better solution would be to assign "mldonkey" as the username and "p2p" as the group. Then, users who want to access the mldonkey homedir just have to be added to the "p2p" group. In the following attachments I have patched the ebuild and the conf.d file to make mldonkey behave as stated. Please review and tell me your thoughts. Reproducible: Always Steps to Reproduce:
Created attachment 24400 [details, diff] Patched ebuild for mldonkey This patch slightly modifies the ebuild to install according to the thoughts stated above.
Created attachment 24401 [details, diff] Patch for /etc/conf.d/mldonkey This patch makes the config file handle the ebuild changes gracefully.
BTW, is it possible to restrict mldonkey from having a shell? Or should I open a new bug for that?
It still hasn't been decided whether or not gentoo will migrate to using /srv. See glep 20 http://www.gentoo.org/proj/en/glep/glep-0020.html
