Bug 393463 – x11-terms/terminator-0.95 has "broken image" icons

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Denilson Sá Maia 2011-12-07 02:14:54 UTC]

After installing x11-terms/terminator-0.95, when we open "terminator" it shows all icons as "broken image". You can see that at the top-left corner, as well as the top-right corner after triggering a "bell".

(by looking at the ebuilds, I think this bug also affects 0.96)

I believe the reason for this is that terminator installs some icons to the /usr/share/icons/hicolor, but it does not update the icon cache, and thus the icons are not found by GTK+.

I can confirm that the terminator icons are displayed correctly after re-emerging x11-themes/hicolor-icon-theme.

By looking at the ebuilds, I believe (but I have not tested) that the solution is adding the following lines to the terminator ebuild:

pkg_postinst() { gnome2_icon_cache_update; }
pkg_postrm() { gnome2_icon_cache_update; }

(the same can be said for any ebuild that installs icons; maybe this check should be done at the QA pass)

[Comment 1 Denilson Sá Maia 2011-12-07 02:16:19 UTC]

Created attachment 295031 [details]
emerge --info

[Comment 2 Justin Lecher (RETIRED) 2011-12-07 07:11:19 UTC]

Thanks for the report.

@gnome
Could you please comment, if the suggested use of "gnome2_icon_cache_update" is the correct proceededing.

[Comment 3 Alexandre Rostovtsev (RETIRED) 2011-12-07 08:13:23 UTC]

(In reply to comment #2)
> Thanks for the report.
> 
> @gnome
> Could you please comment, if the suggested use of "gnome2_icon_cache_update" is
> the correct proceededing.

Ebuilds that install icons and want the new icons to be picked up by gtk need to inherit gnome2-utils and call:

1. gnome2_icon_savelist in pkg_preinst()
2. gnome2_icon_cache_update in pkg_postinst()
3. gnome2_icon_cache_update in pkg_postrm()

Note that gnome.eclass, kde-base.eclass, and xfconf.eclass will take care of this for you automatically. If you do not use any of these eclasses (or something that inherits from them), you will need to manually add the gnome2_icon_savelist and gnome2_icon_cache_update calls to your ebuild.

[Comment 4 Alexandre Rostovtsev (RETIRED) 2011-12-07 08:15:04 UTC]

(In reply to comment #3)
> Ebuilds that install icons

Specifically: ebuilds that install icons in /usr/share/icons or /usr/share/pixmaps.

[Comment 5 Justin Lecher (RETIRED) 2011-12-07 09:49:27 UTC]

+*terminator-0.96-r1 (07 Dec 2011)
+
+  07 Dec 2011; Justin Lecher <[e-mail]> terminator-0.95.ebuild,
+  -terminator-0.96.ebuild, +terminator-0.96-r1.ebuild:
+  Rebuild icon cache correctly, #393463
+