The frei0r-plugins-1.1.22-no-automagic-deps.patch patch that is supposed to fix automagic dep of GAVL (which is needed for scale0tilt, vectorscope AND rgbparade, while controlled by a scale0tilt USE flag) doesn't work really. The package depends on gavl with the USE flag, I have gavl-1.2.0. But what happens is this: checking for GAVL... no configure: WARNING: *** gavl >= 0.2.3 not found - this program enables optional plugin with the gmerlin audio video library >= 0.2.3 http://gmerlin.sourceforge.net/ *** configure: creating ./config.status There are at least two problems with this: 1) If a feature is explicitly requested by --enable-foo, then the feature foo MUST BE possible to be enabled for configure to pass successfully. Here it just contnued on, with the features automagically turned off. In the same vain, if --disable-foo is passed (or --enable-foo=no, this all is handled by autoconf for you and the AC_ARG_ENABLE parameter usage takes care of it all), the features must be disabled, even if foo dependency is present. Only if nothing is explicitly asked, it should automatically be enabling it if possible - this is also easy with standard AC_ARG_ENABLE macro usage. 2) Obviously the check ought to actually pass if I have gavl installed... I need scale0tilt to have pitivi show me ANY frei0r transformations/plugins in the UI, which is a whole different problem I'll need to track with that upstream.
The problem why 2) doesn't work is the following: All usages of the PKG_CHECK_MODULES macros we end up with come from this patch; all of those usages are conditionals. Therefore the following applies from the pkg.m4 documentation or "man pkg-config": "Note that if there is a possibility the first call to PKG_CHECK_MODULES might not happen, you should be sure to include an explicit call to PKG_PROG_PKG_CONFIG in your configure.ac." I ended up with GAVL not seen, because I didn't enable USE=facedetect, which goes into the first conditional use of PKG_CHECK_MODULES, so none of the rest worked either. It would have worked with USE="facedetect scale0tilt", which is probably how this patch was tested originally and assumed to work right. So to fix that, a PKG_PROG_PKG_CONFIG call needs to be added. I temporarily added it after the first + in the patch as a quick hack, and now I do get scale0tilt built. If needed I can later help with getting this whole patch correct in regards to point 1) as well, but not at this very moment, just needed frei0r-plugins in pitivi working quickly for a presentation in a couple hours.
boring. :) switched 1.3 to use cmake. thanks for reporting though
