Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 392921 - media-video/bombono-dvd-1.2.0: make gnome-base/gvfs RDEPEND optional
Summary: media-video/bombono-dvd-1.2.0: make gnome-base/gvfs RDEPEND optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 15:04 UTC by Nikoli
Modified: 2011-12-02 19:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2011-12-02 15:04:41 UTC
bombono-dvd-1.2.0/debian/control has gvfs in Suggests, not in Depends; Changelog tells:
gvfs is needed for web browser integration (Linux)

Please add some USE flag for gvfs RDEPEND.
Comment 1 Nikoli 2011-12-02 15:15:32 UTC
Please also change boost DEPEND, gcc 4.6 is hard masked now and boost 1.47 is not stable yet. May be you just add something like this:
pkg_pretend() {
        if [[ ${MERGE_TYPE} != binary ]]; then
                ( [[ $(gcc-major-version) -eq 4 && $(gcc-minor-version) -ge 6 ]] ) \
                        && ewarn "Building with GCC 4.6 needs >=dev-libs/boost-1.47"
        fi
}

P.S. Not sure if opening one more bug is good idea in this case.
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2011-12-02 19:37:20 UTC
(In reply to comment #0)
> bombono-dvd-1.2.0/debian/control has gvfs in Suggests, not in Depends;
> Changelog tells:
> gvfs is needed for web browser integration (Linux)
> 
> Please add some USE flag for gvfs RDEPEND.

Done, it's now controlled by useflag gnome.

(In reply to comment #1)
> Please also change boost DEPEND, gcc 4.6 is hard masked now and boost 1.47 is
> not stable yet. May be you just add something like this:
> pkg_pretend() {
>         if [[ ${MERGE_TYPE} != binary ]]; then
>                 ( [[ $(gcc-major-version) -eq 4 && $(gcc-minor-version) -ge 6
> ]] ) \
>                         && ewarn "Building with GCC 4.6 needs
> >=dev-libs/boost-1.47"
>         fi
> }

No. gcc 4.6 will be unmasked soon, and bombono is also not stable.