Bug 392669 – dev-lang/erlang-14.2.4 improvements(?)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daniel Goertzen 2011-11-30 19:45:37 UTC]

Created attachment 294385 [details]
ebuild

- Updated ebuild for latest version of Erlang.

- Adds use flag "compat-ethread" to optionally activate pre-Pentium 4 compatibility.

Excerpt from http://www.erlang.org/doc/installation_guide/INSTALL.html#How-to-Build-and-Install-ErlangOTP_Configuring :

"--enable-ethread-pre-pentium4-compatibility - Enable compatibility with x86 processors before pentium 4 (back to 486) in the ethread library. If not passed the ethread library (part of the runtime system) will use instructions that first appeared on the pentium 4 processor when building for x86. This option will be automatically enabled if required on the build machine."

[Comment 1 Agostino Sarubbo 2011-11-30 20:06:16 UTC]

please attach a diff and add die where is required (externalbinary called mv/rm/etc.)

[Comment 2 Daniel Goertzen 2011-11-30 21:38:13 UTC]

Created attachment 294393 [details]
diff -Naur erlang-14.2.3.ebuild erlang-14.2.4.ebuild

[Comment 3 Jeroen Roovers (RETIRED) 2011-12-01 17:24:40 UTC]

Forgot to mention why I changed the Summary:

# ChangeLog for dev-lang/erlang
# Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/dev-lang/erlang/ChangeLog,v 1.212 2011/11/30 15:50:14 djc Exp $

*erlang-14.2.4 (30 Nov 2011)
  
  30 Nov 2011; Dirkjan Ochtman <[e-mail]> +erlang-14.2.4.ebuild:
  Version bump to 14.2.4, fix bug 383697, remove blocker.

[Comment 4 Dirkjan Ochtman (RETIRED) 2011-12-01 22:12:34 UTC]

Daniel, could you please have a look at my ebuild, test it, and see if your changes still apply? I could really use some help with maintaining Erlang.

[Comment 5 Daniel Goertzen 2011-12-02 20:32:01 UTC]

Created attachment 294541 [details]
compat-ethread patch against in-tree erlang-14.2.4.ebuild

Hi Dirkjan.  I tried your ebuild.  The halfword die worked fine (I build on x86).  I didn't test the zlib fix.

I've adjusted my compat-ethread patch.  The ethread-pre-pentium4-compatibility option is a "tristate" option.  In Erlang configure, if neither --enable or --disable is specified, the setting will be automatically detected.  My latest patch will add --enable when USE compat-ethread is present, otherwise it will add nothing.  Adding --disable when the USE flag is absent is the wrong thing to do.

Totally unrelated data point:  I built erlang on armv7 a few months ago and it worked just fine.  This seems to be a solid ebuild.

[Comment 6 Dirkjan Ochtman (RETIRED) 2011-12-02 21:57:10 UTC]

THanks a lot for testing! I will incorporate your patch soon.

[Comment 7 Dennis Schridde 2012-02-26 16:15:07 UTC]

(In reply to comment #6)
> THanks a lot for testing! I will incorporate your patch soon.
Any news about this?

[Comment 8 Dirkjan Ochtman (RETIRED) 2012-03-01 10:08:07 UTC]

I've added this to a new erlang-15.2 ebuild. Thanks!