Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 39248 - phpsysinfo 2.1 doesn't display swap percentage usage on 2.6
Summary: phpsysinfo 2.1 doesn't display swap percentage usage on 2.6
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-24 08:01 UTC by Stephen Reindl
Modified: 2004-08-16 06:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
2.5/6 kernel patch fixed (fix_memory_display_kernel2.5.diff,6.53 KB, patch)
2004-01-24 08:03 UTC, Stephen Reindl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Reindl 2004-01-24 08:01:32 UTC
After installing phpsysinfo 2.1 with kernel 2.5 patch applied, the percentage for swapfile usage is not displayed due to a typo in the patch

Reproducible: Always
Steps to Reproduce:
Comment 1 Stephen Reindl 2004-01-24 08:03:09 UTC
Created attachment 24337 [details, diff]
2.5/6 kernel patch fixed

Fixed patch that should be delivered
Comment 2 Stuart Herbert (RETIRED) gentoo-dev 2004-03-28 14:36:40 UTC
Committed to CVS as phpsysinfo-2.1-r2; should be appearing on an rsync mirror near you in an hour or so.  This release detects which kernel is installed, and uses that to decide whether to auto-patch phpsysinfo or not.

Best regards,
Stu
Comment 3 Roy Marples (RETIRED) gentoo-dev 2004-03-28 23:51:12 UTC
>>> Unpacking phpSysInfo-2.1.tar.gz to /var/tmp/portage/phpsysinfo-2.1-r2/work
 * Applying phpsysinfo_2.1-1.diff.gz...                                   [ ok ] * Applying urlencoded-security-fix.diff...                               [ ok ] * /usr/src/linux is a symbolic link
 * Determining the real directory of the Linux kernel source code
 * Building for Linux 2.6.4 found in /usr/src/linux
 * /usr/src/linux is a symbolic link
 * Determining the real directory of the Linux kernel source code
 * Building for Linux 2.6.4 found in /usr/src/linux
 * Applying fix_memory_display_kernel2.5.diff.gz...                       [ ok ]>>> Source unpacked.
make: *** No targets specified and no makefile found.  Stop.
 
!!! ERROR: dev-php/phpsysinfo-2.1-r2 failed.
!!! Function kernel-mod_src_compile, Line 156, Exitcode 2
!!! (no error message)
 
Looks like there's a problem with the ebuild. And shouldn't this be marked ~x86?
Comment 4 Antonio 2004-03-29 00:29:02 UTC
I have this problem with this update:

Calculating dependencies ...done!
>>> emerge (1 of 1) dev-php/phpsysinfo-2.1-r2 to /
>>> md5 src_uri ;-) phpSysInfo-2.1.tar.gz
>>> md5 src_uri ;-) phpsysinfo_2.1-1.diff.gz
>>> Unpacking source...
>>> Unpacking phpSysInfo-2.1.tar.gz to /var/tmp/portage/phpsysinfo-2.1-r2/work
 * Applying phpsysinfo_2.1-1.diff.gz...                                   [ ok ]
 * Applying urlencoded-security-fix.diff...                               [ ok ]
 * /usr/src/linux is a symbolic link
 * Determining the real directory of the Linux kernel source code
 * Building for Linux 2.4.25 found in /usr/src/linux
 * /usr/src/linux is a symbolic link
 * Determining the real directory of the Linux kernel source code
 * Building for Linux 2.4.25 found in /usr/src/linux
>>> Source unpacked.
make: *** No targets specified and no makefile found.  Stop.

!!! ERROR: dev-php/phpsysinfo-2.1-r2 failed.
!!! Function kernel-mod_src_compile, Line 156, Exitcode 2
!!! (no error message)

I have kernel 2.4.25 vanilla
Comment 5 Stephen Reindl 2004-03-30 08:14:43 UTC
Besides the problems that the other testers reported (which I didn't see with 2.6.4 gentoo-dev r1) the script is missing two '$' signs to test for 2.5 and 2.6.

Original lines:
   kernel-mod_is_2_4_kernel && APPLY_25PATCH=0
    [ "$APPLY_25PATCH" = "-1" ] && kernel-mod_is_2_5_kernel && APPLY_25PATCH=1
    [ "APPLY_25PATCH" = "-1" ] && kernel-mod_is_2_6_kernel && APPLY_25PATCH=1
    [ "APPLY_25PATCH" = "1" ] && epatch ${FILESDIR}/fix_memory_display_kernel2.5.diff.gz


Modified lines:
   kernel-mod_is_2_4_kernel && APPLY_25PATCH=0
    [ "$APPLY_25PATCH" = "-1" ] && kernel-mod_is_2_5_kernel && APPLY_25PATCH=1
    [ "$APPLY_25PATCH" = "-1" ] && kernel-mod_is_2_6_kernel && APPLY_25PATCH=1
    [ "$APPLY_25PATCH" = "1" ] && epatch ${FILESDIR}/fix_memory_display_kernel2.5.diff.gz
Comment 6 Stuart Herbert (RETIRED) gentoo-dev 2004-03-30 11:51:56 UTC
Doh ;(  My bad.  I've committed the fix to CVS - should be showing up on an rsync mirror near you in the hour.

Thanks!
Stu
Comment 7 Stephen Reindl 2004-04-01 10:03:58 UTC
Fine for me now
Comment 8 Stuart Herbert (RETIRED) gentoo-dev 2004-08-16 06:01:29 UTC
Closing old bug