Bug 392045 – x11-misc/dmenu app-misc/lsx net-dialup/lrzsz file collision on /usr/bin/lsx

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Roger 2011-11-27 03:14:37 UTC]

Please add comments when unusual circumstances occur, such as when completely unrelated packages are blocked and the reason being 'file overwrites'.

These bugs should probably also be reported upstream to the dmenu author as  lrzsz package is quite old, making the dmenu author likely in need of renaming his lsx binary!

Suggested patch adds a comment:
--- dmenu-4.4.1.ebuild.orig     2011-11-26 18:09:27.799809745 -0900
+++ dmenu-4.4.1.ebuild  2011-11-26 18:10:13.894810229 -0900
@@ -17,6 +17,8 @@
 
 DEPEND="x11-libs/libX11
        xinerama? ( x11-libs/libXinerama )"
+
+# This packages also install /usr/bin/lsx, conflicting with dmenu
 RDEPEND="${DEPEND}
        !app-misc/lsx
        !net-dialup/lrzsz"


Reproducible: Always

[Comment 1 Roger 2011-11-27 03:15:34 UTC]

This is for >= =x11-misc/dmenu-4.4.1 ebuilds.

[Comment 2 Roger 2011-11-27 03:32:02 UTC]

net-dialup/lrzsz is a depend for the following packages:

net-dialup/minicom
app-misc/ckermit


A question in my head, how can something like this have slipped into the dmenu package?

[Comment 3 Roger 2011-11-27 22:12:38 UTC]

Well, it's pretty much settled at the developers' end.  They are not renaming lsx, and it has been brought up in the past.

http://lists.suckless.org/dev/1111/10248.html

At this point, I suggest making the dmenu ebuild's rename the lsx binary to something other such as /usr/bin/dmenu-lsx or /usr/bin/dmenu_lsx.


Renaming lsx will also entail renaming the occurances within /usr/bin/dmenu_run, and I believe this is the only place lsx is used.  I'll try to hack-out a patch today if nobody else responds within the few hours or so.

[Comment 4 Roger 2011-11-27 23:49:39 UTC]

Created attachment 293997 [details]
dmenu-4.4.1-r1.ebuild

# diff dmenu-4.4.1.ebuild dmenu-4.4.1-r1.ebuild
7c7
< inherit toolchain-funcs
---
> inherit eutils toolchain-funcs
20,22d19
< RDEPEND="${DEPEND}
<       !app-misc/lsx
<       !net-dialup/lrzsz"
30a28,31
>       
>       # Rename lsx to dmenu_lsx: See Bug #392045
>       epatch "${FILESDIR}/dmenu-4.4.1-rename_lsx.patch"
>       epatch "${FILESDIR}/dmenu-4.4.1-rename_lsx-manpage.patch"
42c43,54
<       emake DESTDIR="${D}" PREFIX="/usr" install
---
> 
>       insinto /usr/bin
>               dobin  dmenu dmenu_run || die
> 
>       # Rename lsx to dmenu_lsx: See Bug #392045
>       newbin lsx dmenu_lsx || die
> 
>       dodoc README || die
>       doman dmenu.1 || die
> 
>       # Rename lsx to dmenu_lsx: See Bug #392045
>       newman lsx.1 dmenu_lsx.1

[Comment 5 Jeroen Roovers (RETIRED) 2011-11-27 23:50:47 UTC]

*** This bug has been marked as a duplicate of bug 376675 ***

[Comment 6 Roger 2011-11-27 23:52:32 UTC]

Created attachment 293999 [details, diff]
dmenu-4.4.1-rename_lsx.patch

Renames the call of the lsx binary from within the dmenu_run script to dmenu_lsx.

[Comment 7 Roger 2011-11-27 23:54:31 UTC]

Created attachment 294003 [details, diff]
dmenu-4.4.1-rename_lsx-manpage.patch

Renames the the references to lsx to refer to dmenu_lsx.  But keeping the surrounding LSX in within the four corners of the manpage to LSX, so people will have an idea of the original name of lsx.

[Comment 8 Roger 2011-11-28 00:02:01 UTC]

The above patches drop the package conflicts with app-misc/lsx and net-dialup/lrzsz.  Us DWM/DMenu users can once again install minicom &/or ckermit!

My only gripe with this, I should have merged the two patches into one file.  Let me know if it's preferred to merge and I'll resubmit the ebuild and patch files.


As far as my changes, I really doubt anybody is going to have any issues with the renaming lsx to dmenu_lsx, as lsx is rarely - if ever - used by the end user.  

The dmenu binary is likely the only executable used by end users, even the manual pages are probably rarely, if ever, used -- but present.

[Comment 9 Jeroen Roovers (RETIRED) 2011-11-28 00:02:08 UTC]

Fixed in 4.4.1-r1. Thanks for reporting.

[Comment 10 Jeroen Roovers (RETIRED) 2011-11-28 00:06:33 UTC]

Comment on attachment 294003 [details, diff]
dmenu-4.4.1-rename_lsx-manpage.patch

Ah thanks, added something similar to the ebuild later on.

[Comment 11 Jeroen Roovers (RETIRED) 2011-11-28 00:07:02 UTC]

(In reply to comment #8)
> The above patches drop the package conflicts with app-misc/lsx and
> net-dialup/lrzsz.  Us DWM/DMenu users can once again install minicom &/or
> ckermit!
> 
> My only gripe with this, I should have merged the two patches into one file. 

I went for sed magic instead.

[Comment 12 Roger 2011-11-28 00:11:51 UTC]

Created attachment 294005 [details]
dmenu-4.4.1-r1.ebuild

Modified to use one patch file instead of two.

[Comment 13 Roger 2011-11-28 00:13:30 UTC]

Created attachment 294009 [details]
dmenu-4.4.1-rename_lsx.patch

Modified the original to use one patch instead of two patch files.

[Comment 14 Roger 2011-11-28 00:14:13 UTC]

ah. ok. then ignore my stuff then.  Cheers!

[Comment 15 Roger 2011-11-28 00:26:34 UTC]

Tested (my patches) on x86, dmenu & manpage dmenu_lsx seems stable/working.

[Comment 16 Jeroen Roovers (RETIRED) 2012-01-31 17:13:11 UTC]

*** Bug 401649 has been marked as a duplicate of this bug. ***