Bug 391239 – Please stabilise app-admin/chrpath-0.13-r2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Fabian Groffen 2011-11-21 12:45:19 UTC]

Target: amd64 arm ppc x86

Please stabilise chrpath-0.13-r2.  It's easily tested by modifying an ELF object's RUNPATH:

[ra:/var/tmp] % echo "main() {}" | gcc -o test -Wl,--rpath=/var/tmp/blavlabla -xc -
[ra:/var/tmp] % scanelf --rpath test
 TYPE   RPATH FILE 
ET_EXEC /var/tmp/blavlabla test 
[ra:/var/tmp] % chrpath -l test
test: RPATH=/var/tmp/blavlabla
[ra:/var/tmp] % chrpath -r /new/path test
test: RPATH=/var/tmp/blavlabla
test: new RPATH: /new/path
[ra:/var/tmp] % scanelf --rpath test
 TYPE   RPATH FILE 
ET_EXEC /new/path test

[Comment 1 Agostino Sarubbo 2011-11-21 17:47:43 UTC]

This is not a correct way to disable static, please review it because configure script supports enable/disable static

amd64 ok

[Comment 2 Fabian Groffen 2011-11-21 17:58:09 UTC]

(In reply to comment #1)
> This is not a correct way to disable static, please review it because configure
> script supports enable/disable static

hints welcome

is ok for me to block stabilisation

[Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) 2011-11-21 18:29:29 UTC]

(In reply to comment #2)
> (In reply to comment #1)
> > This is not a correct way to disable static, please review it because configure
> > script supports enable/disable static
> 
> hints welcome

econf $(use_enable static_libs static)
+
remove .la files conditionally
use static-libs || ...

[Comment 4 Agostino Sarubbo 2011-11-21 18:58:32 UTC]

Created attachment 293351 [details, diff]
ebuild.patch

ebuild cleanup/eapi bump included

[Comment 5 Fabian Groffen 2011-11-21 19:28:40 UTC]

thanks(In reply to comment #4)
> Created attachment 293351 [details, diff] [details, diff]
> ebuild.patch
> 
> ebuild cleanup/eapi bump included

Thanks!  However, I don't see the need for the EAPI bump, it pollutes the actual "fix" IMO.

[Comment 6 Fabian Groffen 2011-11-29 18:38:51 UTC]

Suggested changes committed.

[Comment 7 Agostino Sarubbo 2011-11-29 19:57:21 UTC]

amd64 ok

[Comment 8 Markus Meier 2011-12-03 11:00:30 UTC]

arm stable

[Comment 9 Markos Chandras (RETIRED) 2011-12-04 12:44:09 UTC]

amd64 done. Thanks Agostino

[Comment 10 Paweł Hajdan, Jr. (RETIRED) 2011-12-07 07:45:57 UTC]

x86 stable

[Comment 11 Brent Baude (RETIRED) 2012-01-09 19:54:16 UTC]

ppc done; closing as last arch