Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 390191 - dev-util/perf-3.1: broken configure
Summary: dev-util/perf-3.1: broken configure
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 15:41 UTC by SpanKY
Modified: 2012-02-28 22:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2011-11-11 15:41:50 UTC
perf_make() does things like:
    use perl || makeargs="${makeargs} NO_LIBPERL= "

the perf makefile looks like:
ifdef NO_LIBPERL
    ... disable perl ...
else
    ... enable perl ...
endif

setting NO_LIBPERL= doesn't actually disable the code.  you need to do something like NO_LIBPERL=1.  the code could be simplified nicely as well if you used the new usex() helper in eutils.eclass:
    emake \
        NO_DEMANGLE=$(usex demangle no "") \
        NO_LIBPERL=$(usex perl no "") \
        ...

(issue noticed/fixed by Sonny Rao)

while you're here, you should also fix the $arch handling.  pretty sure that should be doing ARCH=$(tc-arch-kernel) instead of attempting to parse it manually.
Comment 1 SpanKY gentoo-dev 2012-02-28 22:20:46 UTC
fixed myself in perf-3.2 among other things