Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 389693 - python-nss-0.8-r1: ebuild cleanup
Summary: python-nss-0.8-r1: ebuild cleanup
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Maxim Koltsov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-06 05:53 UTC by Peter Volkov (RETIRED)
Modified: 2012-03-24 10:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2011-11-06 05:53:55 UTC
Instead of this

src_prepare() {
    epatch "${FILESDIR}"/*.patch
}

please, use epatch with patch tarball and correct patch naming. For single patch this looks like asking for troubles. Also why commit package with warnings like this:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * src/py_nspr_io.c:1236:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1236:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1242:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1242:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1245:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1245:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1289:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1289:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1292:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1292:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1298:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:1298:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:2830:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:2833:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nspr_io.c:2836:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:3556:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:3558:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:3593:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:3595:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4566:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4568:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4583:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4585:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4600:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:4602:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6892:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6893:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6894:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6895:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6896:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6897:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6898:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6899:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6900:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6901:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6902:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6903:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6904:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_nss.c:6905:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:1326:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:1328:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:2014:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:2016:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:2079:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:2081:9: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * src/py_ssl.c:2268:5: warning: dereferencing type-punned pointer will break strict-aliasing rules

Yea I know that this should be upstreamed, but I see not reference to bug report at least and IMO commiting new packages with such crap should be prohibited and I have feeling that QA team agrees with me on this bit. Also fixing this is not hard, just takes some time ;)
Comment 1 Maxim Koltsov (RETIRED) gentoo-dev 2011-11-06 08:26:50 UTC
Strange, but i don't get all that QA errors. wtf?
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2011-11-06 13:51:18 UTC
(In reply to comment #1)
> Strange, but i don't get all that QA errors. wtf?

Try to:
1. specify -Wall in CFLAGS
2. build with LC_MESSAGES="C"
Comment 3 Andreis Vinogradovs ( slepnoga ) 2011-11-16 22:04:17 UTC
Please, post you dev-libs/nss version.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-03-24 10:04:58 UTC
Reopen if the problem exist with the latest version