Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 389377 - www-client/surfraw bash-completion-r1 + other niggles from 389333
Summary: www-client/surfraw bash-completion-r1 + other niggles from 389333
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 22:00 UTC by James Rowe
Modified: 2011-11-03 15:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
full.patch (full.patch,1.15 KB, patch)
2011-11-02 22:00 UTC, James Rowe
Details | Diff
Switch-to-bash-completion-r1-eclass.patch (0001-Switch-to-bash-completion-r1-eclass.patch,1.07 KB, patch)
2011-11-02 22:01 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2011-11-02 22:00:20 UTC
In #389333 Agostino Sarubbo made a few suggestions for improvements to the
surfraw ebuild[1], this bug follows through on them.

* Use ``bash-completion-r1``
  [meant to open a bug when I updated my live ebuild[2], but I didn't
   get around to it.]

* Remove the symlink fixing hack
  For the "die after sed" issue perhaps just allow portage to handle fixing the
  manpages as it now works correctly in all current versions.  Allows me to
  neatly sidestep my hatred of "sed || die" too :)

* ``DOCS`` instead of ``dodoc``
  Done, but not sure it provides any value when an ebuild has a custom src_install
  phase.

Thanks,

James

Jeroen:

  I'll attach ``full.patch`` that does all three things, and I'll also attach
just the ``bash-completion-r1`` change separately.  Don't know how you'll feel
about the second/third point, so hopefully the separate attachments make life
easier for you.

1. https://bugs.gentoo.org/show_bug.cgi?id=389333#c1
2. https://github.com/JNRowe/jnrowe-misc/commit/899e72f69b0b1548e7856061807b20b2a094e97b

Reproducible: Always
Comment 1 James Rowe 2011-11-02 22:00:39 UTC
Created attachment 291555 [details, diff]
full.patch
Comment 2 James Rowe 2011-11-02 22:01:07 UTC
Created attachment 291557 [details, diff]
Switch-to-bash-completion-r1-eclass.patch
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2011-11-03 15:22:19 UTC
All three issues fixed without a revision bump.