In #389333 Agostino Sarubbo made a few suggestions for improvements to the surfraw ebuild[1], this bug follows through on them. * Use ``bash-completion-r1`` [meant to open a bug when I updated my live ebuild[2], but I didn't get around to it.] * Remove the symlink fixing hack For the "die after sed" issue perhaps just allow portage to handle fixing the manpages as it now works correctly in all current versions. Allows me to neatly sidestep my hatred of "sed || die" too :) * ``DOCS`` instead of ``dodoc`` Done, but not sure it provides any value when an ebuild has a custom src_install phase. Thanks, James Jeroen: I'll attach ``full.patch`` that does all three things, and I'll also attach just the ``bash-completion-r1`` change separately. Don't know how you'll feel about the second/third point, so hopefully the separate attachments make life easier for you. 1. https://bugs.gentoo.org/show_bug.cgi?id=389333#c1 2. https://github.com/JNRowe/jnrowe-misc/commit/899e72f69b0b1548e7856061807b20b2a094e97b Reproducible: Always
Created attachment 291555 [details, diff] full.patch
Created attachment 291557 [details, diff] Switch-to-bash-completion-r1-eclass.patch
All three issues fixed without a revision bump.