Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 389137 - Support building www-client/firefox-7.0.1 without methodjit (patch)
Summary: Support building www-client/firefox-7.0.1 without methodjit (patch)
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 22:46 UTC by Palmer Dabbelt
Modified: 2012-06-06 02:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
www-client/firefox-7.0.1-r1 with jit useflag (firefox-7.0.1-r1.ebuild,11.04 KB, text/plain)
2011-10-31 22:46 UTC, Palmer Dabbelt
Details
patch for www-client/firefox-7.0.1-r1 (firefox-7.0.1-r1.ebuild.patch,966 bytes, patch)
2011-10-31 22:47 UTC, Palmer Dabbelt
Details | Diff
www-client/firefox-8.0 with jit useflag (firefox-8.0.ebuild,11.03 KB, application/octet-stream)
2011-11-16 16:28 UTC, Palmer Dabbelt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Palmer Dabbelt 2011-10-31 22:46:09 UTC
Created attachment 291389 [details]
www-client/firefox-7.0.1-r1 with jit useflag

Firefox now has a javascript JIT, which causes trouble for both PAX users and anyone restricted to using gcc earlier than 4.5 (for example, prefix users stuck on an old glibc like me).

I propose adding a the "jit" useflag to firefox, which disables jit, as suggested here

http://hardenedgentoo.blogspot.com/2011/06/firefox-5-with-mprotect-onof-course.html

Attached is an updated ebuild with the above change, as well as a patch for the current ebuild.  The attached ebuild builds on my amd64-linux prefix with 'USE="-jit"'.
Comment 1 Palmer Dabbelt 2011-10-31 22:47:16 UTC
Created attachment 291391 [details, diff]
patch for www-client/firefox-7.0.1-r1

Added the patch as well, as I created my ebuild from the prefix tree and it may be incompatible with the real gentoo tree.
Comment 2 Jory A. Pratt gentoo-dev 2011-11-01 01:28:06 UTC
hardened is not effected we have worked around the issue for them, as far as prefix goes this belongs in their overlay not gonna happen in the main tree.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-11-01 01:58:05 UTC
(In reply to comment #0)

> Firefox now has a javascript JIT, which causes trouble for both PAX users and
> anyone restricted to using gcc earlier than 4.5 (for example, prefix users
> stuck on an old glibc like me).

Uhm, why are you "stuck" with an old gcc exactly? The prefix team doesn't want to fork packages, this is directly against our end goal..
Comment 4 Palmer Dabbelt 2011-11-01 04:54:19 UTC
(In reply to comment #3)
> (In reply to comment #0)
> 
> > Firefox now has a javascript JIT, which causes trouble for both PAX users and
> > anyone restricted to using gcc earlier than 4.5 (for example, prefix users
> > stuck on an old glibc like me).
> 
> Uhm, why are you "stuck" with an old gcc exactly? The prefix team doesn't want
> to fork packages, this is directly against our end goal..

My prefix is hosted on CentOS 5, and I can't get a GCC newer than 4.2 to compile with the provided glibc.

As to the package: it's not really a fork (though I suppose it is if gentoo-portage doesn't want the patch), this is just an option to mozilla's configure that wasn't exposed via USE flags but that seems to be used (people in #gentoo-prefix said it was a known problem, so I'm assume there's more than just me who has this in their own overlay).  If nobody wants the patch then it's fine by me, I don't mind maintaining it in my personal overlay.  I was just trying to reduce the overhead of people having to run to IRC for help.

Feel free to close the bug if you don't think it's useful, sorry for the trouble.
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-11-16 16:19:46 UTC
(In reply to comment #4)

> As to the package: it's not really a fork (though I suppose it is if
> gentoo-portage doesn't want the patch), this is just an option to mozilla's

All of our firefox comes directly from Gentoo Linux, so it would be a "fork" to maintain it in the prefix overlay.

> Feel free to close the bug if you don't think it's useful, sorry for the
> trouble.

Useful, but we will have to find other alternatives as the prefix team doesn't have resources to accommodate you =/ Sorry.
Comment 6 Palmer Dabbelt 2011-11-16 16:27:12 UTC
(In reply to comment #5)
> Useful, but we will have to find other alternatives as the prefix team doesn't
> have resources to accommodate you =/ Sorry.

If it's just a problem of ebuild maintenance, I will maintain the ebuild (as I have to anyway for myself).  I already run a ~amd86-linux prefix, so I should be able to stay fairly up-to-date.
Comment 7 Palmer Dabbelt 2011-11-16 16:28:12 UTC
Created attachment 292777 [details]
www-client/firefox-8.0 with jit useflag

The patch is the same
Comment 8 Fabian Groffen gentoo-dev 2011-11-30 13:56:49 UTC
could your gcc compile problem, perhaps be this default fortification patch (can't find bug atm)
Comment 9 Palmer Dabbelt 2011-11-30 16:05:28 UTC
(In reply to comment #8)
> could your gcc compile problem, perhaps be this default fortification patch
> (can't find bug atm)

Sorry, I don't understand what that means.
Comment 10 Fabian Groffen gentoo-dev 2011-11-30 16:25:06 UTC
see https://bugs.gentoo.org/show_bug.cgi?id=289757
Comment 11 Palmer Dabbelt 2011-11-30 18:53:35 UTC
(In reply to comment #10)
> see https://bugs.gentoo.org/show_bug.cgi?id=289757

I still get some errors even with USE="vanilla" for gcc.  I opened a bug

https://bugs.gentoo.org/show_bug.cgi?id=392655
Comment 12 Palmer Dabbelt 2012-06-06 02:14:17 UTC
As of www-client/firefox-12.0-r2 (possibly earlier) in Gentoo the jit use flag has been added.  This makes my original request obselete, so I think it should be closed.
Comment 13 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-06-06 02:16:01 UTC
great, thx