Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 38913 - /usr/bin/MozillaFirebird should open new tabs by default, or be configurable
Summary: /usr/bin/MozillaFirebird should open new tabs by default, or be configurable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Aron Griffis (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-21 06:07 UTC by trejkaz
Modified: 2004-03-18 21:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trejkaz 2004-01-21 06:07:50 UTC
Running MozillaFirebird from /usr/bin/MozillaFirebird, which is typically run for links from other applications, opens all links in a new window.  This is a useability issue which doesn't seem to be solveable even by using the Tabbed Browsing Extension, and having all links spawn in a new window defeats the purpose of having tabs in the first place.


Reproducible: Always
Steps to Reproduce:
1. Click on a link from an external application.

Actual Results:  
A new Mozilla Firebird window pops up.


Expected Results:  
Opened a new tab containing the page.
Comment 1 trejkaz 2004-01-21 06:21:40 UTC
Here is the /usr/bin/MozillaFirebird script I always copy over /usr/bin/MozillaFirebird after every update:

--- begin /usr/bin/MozillaFirebird
#!/bin/sh

export MOZILLA_FIVE_HOME="/usr/lib/MozillaFirebird"

${MOZILLA_FIVE_HOME=}/MozillaFirebird -remote "openURL($@ ,new-tab)" || exec ${MOZILLA_FIVE_HOME=}/MozillaFirebird $@
--- end /usr/bin/MozillaFirebird

If users still want new window mode then configuration will be needed.  Is it reasonable to put an environment variable sourced from some file in /etc?  Sort of like...

--- begin /etc/mozilla.conf
REMOTE_LAUNCH_MODE=new-tab
--- end /etc/mozilla.conf

--- begin /usr/bin/MozillaFirebird
#!/bin/sh

export MOZILLA_FIVE_HOME="/usr/lib/MozillaFirebird"
. /etc/mozilla.conf

${MOZILLA_FIVE_HOME=}/MozillaFirebird -remote "openURL($@ ,$REMOTE_LAUNCH_MODE)" || exec ${MOZILLA_FIVE_HOME=}/MozillaFirebird $@
--- end /usr/bin/MozillaFirebird
Comment 2 trejkaz 2004-01-21 06:22:48 UTC
Oops.  A couple of typos found there way in somehow.  Remove the extraneous '=' signs from the launch lines.
Comment 3 SpanKY gentoo-dev 2004-01-21 15:38:09 UTC
/etc/mozilla.conf seems kind of dumb (no offense)

perhaps ${HOME}/.phoenix/mozilla.conf would be better
Comment 4 trejkaz 2004-01-21 17:44:50 UTC
No offense taken, and you're right, I don't know what the hell I was thinking.

I guess I wanted a sane default so users don't have to edit it in separately.  Maybe just make new-tab the default in the script but the but the user can override it to new-window if they're a big fan of that behaviour.  That being said, I asked around a few firebird users and they all seemed to be really happy when I told them what file to hack to fix the behaviour.

If it's going to be in ~/.phoenix, ~/.phoenix/remote.conf sounds better since it's more specific (~/.phoenix/mozilla.conf is sort of redundant since Phoenix is about to _be_ Mozilla.)

You know to be completely customisation-happy, you _could_ make it ~/.phoenix/remote.sh, which is exec'd "if [ -x ~/.phoenix/remote.sh ]". :-)
Comment 5 Aron Griffis (RETIRED) gentoo-dev 2004-03-18 21:27:08 UTC
This is fixed in the firefox script.  Look at the top of the script; you can set MOZILLA_NEWTYPE=tab in your environment if you want.