38866 – genkernel's linuxrc script sets MY_HWOPTS incorrectly

Bug 38866 - genkernel's linuxrc script sets MY_HWOPTS incorrectly

Summary: genkernel's linuxrc script sets MY_HWOPTS incorrectly

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	genkernel (show other bugs)
Hardware:	All Linux

Importance:	High major (vote)
Assignee:	Brad House

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-01-20 18:45 UTC by Andy Wang
Modified:	2004-01-29 17:20 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Wang 2004-01-20 18:45:53 UTC

genkernel 3.0.1_beta6 linuxrc script looks like it's incorrectly handling MY_HWOPTS variable.  Line 51 reads:
                        MY_HWOPTS="MY_HWOPTS $x"
Should this not be
MY_HWOPTS="${MY_HWOPTS} $x"
since it seems to me that it should be adding to MY_HWOPTS not replacing it with the literal string MY_HWOPTS plus whatever x currently is.  This kind of prevents module loading from working properly with genkernel 3.0.1_beta6.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1 Brad House 2004-01-29 17:20:09 UTC

hah, good catch ...
fixed in cvs, should be in _beta9